Add libfunc validation #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Scarb needs bumping here chainlink-starknet/.github/actions/install-cairo/action.yml Lines 9 to 12 in 9bdc965 |
cfal
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/BCI-1424
Note: this uses Scarb v0.4.0 (Cairo v1.1.0), however, there is no way to specify the Scarb version in the toml config file. The Scarb version is only defined in the CI.
For the latest Cairo version running on testnet (v1.1.0), we currently use some disallowed Sierra libfuncs in our contracts, namely
upcast,downcast,ec_point_from_x_nz. These libfuncs are missing from the current testnet allowlist but are in the audited allowlist in the latest Cairo release candidate v2.0.0-rc2.This means that our Starknet contracts are not deployable until Cairo v2 is released, and a todo has been left to update the allowlist being used after the Cairo v2 release