Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BCI-2714]: adds sncast scripts V2 #405

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

chris-de-leon-cll
Copy link
Contributor

@chris-de-leon-cll chris-de-leon-cll commented Apr 4, 2024

Adds various fixes to: #396:

  • Adds a --max-fee flag to the testnet account deployment command
  • In read_decimals.cairo, the "read_decimals" selector has been replaced with "decimals"
  • Resolves an issue with the make ac-set-answer command on testnet where calling it with a non-mock aggregator contract throws a read access permission error
  • Updates the hardcoded class hashes and addresses in the example scripts (the updates to snfoundry, scarb, and cairo have caused these to change)

@chris-de-leon-cll chris-de-leon-cll self-assigned this Apr 4, 2024
@chris-de-leon-cll chris-de-leon-cll changed the title [BCI-2714]: adds sncast scripts [BCI-2714]: adds sncast scripts V2 Apr 4, 2024
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@archseer archseer merged commit c5977c4 into develop Apr 8, 2024
19 checks passed
@archseer archseer deleted the feat/BCI-2714-sncast-scripts-v2 branch April 8, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants