Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Satisfy Relayer interface with unsupported NewContractReader impl. #434

Merged
merged 6 commits into from
May 27, 2024
Merged

Satisfy Relayer interface with unsupported NewContractReader impl. #434

merged 6 commits into from
May 27, 2024

Conversation

ilija42
Copy link
Contributor

@ilija42 ilija42 commented May 22, 2024 •
edited
Loading

core ref: ef2013a4095934cf0c46930128f69d61cedd4fca

This was referenced May 23, 2024
Merged
Merged
@ilija42 ilija42 force-pushed the relayer-contractreader branch from f2915c4 to 0ea3378 Compare May 23, 2024 15:24
@ilija42 ilija42 force-pushed the relayer-contractreader branch from 0ea3378 to 4fd2d9e Compare May 23, 2024 15:26
@ilija42 ilija42 force-pushed the relayer-contractreader branch from 4fd2d9e to 28f898f Compare May 23, 2024 15:58
@ilija42 ilija42 requested a review from jmank88 May 23, 2024 16:44
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

@archseer archseer merged commit 56197f1 into develop May 27, 2024
22 of 27 checks passed
@archseer archseer deleted the relayer-contractreader branch May 27, 2024 07:32
augustbleeds added a commit that referenced this pull request Jun 17, 2024
@augustbleeds
Revert "Satisfy Relayer interface with unsupported NewContractReader …
40a18f0 
…impl. (#434)"

This reverts commit 56197f1.
@augustbleeds augustbleeds mentioned this pull request Jun 17, 2024
Merged
chray-zhang pushed a commit that referenced this pull request Nov 25, 2024
@ilija42
Satisfy Relayer interface with unsupported NewContractReader impl. (#434
fec5a0b 
)

* Satisfy Relayer interface with unsupported NewContractReader impl.

* Update ChainReader type from common naming to ContractReader

* update refs

* tidy

* Update refs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archseer archseer archseer approved these changes

@jmank88 jmank88 Awaiting requested review from jmank88

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilija42 @archseer