Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
shileiwill committed May 31, 2024
1 parent f4c9ed4 commit 0e28ce4
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 61 deletions.
30 changes: 2 additions & 28 deletions contracts/src/v0.8/automation/dev/v2_3/AutomationRegistrar2_3.sol
Original file line number Diff line number Diff line change
Expand Up @@ -120,20 +120,7 @@ contract AutomationRegistrar2_3 is TypeAndVersionInterface, ConfirmedOwner, IERC
mapping(bytes32 => PendingRequest) private s_pendingRequests;
mapping(uint8 => TriggerRegistrationStorage) private s_triggerRegistrations;

event RegistrationRequested(
bytes32 indexed hash,
string name,
bytes encryptedEmail,
address indexed upkeepContract,
uint32 gasLimit,
address adminAddress,
uint8 triggerType,
bytes triggerConfig,
bytes offchainConfig,
bytes checkData,
uint96 amount,
IERC20 billingToken
);
event RegistrationRequested(bytes32 indexed hash, RegistrationParams registrationParams);

event RegistrationApproved(bytes32 indexed hash, string displayName, uint256 indexed upkeepId);

Expand Down Expand Up @@ -362,20 +349,7 @@ contract AutomationRegistrar2_3 is TypeAndVersionInterface, ConfirmedOwner, IERC
revert DuplicateEntry();
}

emit RegistrationRequested(
hash,
params.name,
params.encryptedEmail,
params.upkeepContract,
params.gasLimit,
params.adminAddress,
params.triggerType,
params.triggerConfig,
params.offchainConfig,
params.checkData,
params.amount,
params.billingToken
);
emit RegistrationRequested(hash, params);

uint256 upkeepId;
if (_shouldAutoApprove(s_triggerRegistrations[params.triggerType], sender)) {
Expand Down
Loading

0 comments on commit 0e28ce4

Please sign in to comment.