[BCI-3837] - Remove tautological check inside EVM TXM (#13857)

* remove tautological err check * add changeset
smartcontractkit · Jul 16, 2024 · 6bf25fc · 6bf25fc
1 parent 873abac
commit 6bf25fc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/.changeset/dull-seals-jog.md b/.changeset/dull-seals-jog.md
@@ -0,0 +1,5 @@
+---
+"chainlink": patch
+---
+
+remove tautological err check within evm txm. #internal
diff --git a/core/chains/evm/txmgr/evm_tx_store.go b/core/chains/evm/txmgr/evm_tx_store.go
@@ -1704,9 +1704,7 @@ func (o *evmTxStore) UpdateTxUnstartedToInProgress(ctx context.Context, etx *Tx,
 				pqErr.ConstraintName == "eth_tx_attempts_eth_tx_id_fkey" {
 				return txmgr.ErrTxRemoved
 			}
-			if err != nil {
-				return pkgerrors.Wrap(err, "UpdateTxUnstartedToInProgress failed to create eth_tx_attempt")
-			}
+			return pkgerrors.Wrap(err, "UpdateTxUnstartedToInProgress failed to create eth_tx_attempt")
 		}
 		dbAttempt.ToTxAttempt(attempt)
 		var dbEtx DbEthTx