-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed spammy error log to debug #13153
Conversation
I see you updated files related to
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and confirmed that this fixes the spam error logs.
(cherry picked from commit 3502176)
* Fix metric description on mercury_transmit_queue_load * Add changeset * Add changesets tag * Decouple gas tests (#12972) * Add first version of evm utils * Remove unused context util * Add WSServer tests * Add NewLegacyTransaction test * Update NewTestChainScopedConfig to apply correct defaults * Decouple gas package tests from core * Move testutils * Update paths * Fix import error * Add changeset * Add logs to identify when assumptions of log queuing behaviour are violated (#12846) * Add logs to identify when assumptions of log queuing behaviour are violated * Add tests * go import * Add changeset * Update enqueuing assumption * Update tests * Extract block tracking into a separate function * Clean up outdated enqueued blocks * Clean up imports * Ignore reord buffer in cleanup * Cleanup test name * tools/docker: bump postgres to v14 (#13156) * changed spammy error log to debug (#13153) * [KS-186] Add custom OCR3 Capability Provider (#13137) * [KS-193] Pass MercuryTriggerService to Mercury Transmitter (#13118) 1. Add EnableTriggerCapability flag to Relay config 2. Create MercuryTriggerService lazily, on the first call to NewMercuryProvider() 3. Make it available in the Transmitter (no-op for now) * update changeset to include db_update tag (#13170) * fix go-etheruem compatibility pipeline trigger (#13162) * Revert "Add logs to identify when assumptions of log queuing behaviour are violated" (#13173) * Revert "Add logs to identify when assumptions of log queuing behaviour are vi…" This reverts commit 6a342ae. * Add changeset * chore: update solana-build-contracts for node20 (#13175) * chore: update solana-build-contracts for node20 * chore: bump chainlink-solana version * Decouple utils tests from core (#12993) * Add first version of evm utils * Remove unused context util * Add WSServer tests * Add NewLegacyTransaction test * Update NewTestChainScopedConfig to apply correct defaults * Move testutils * Decouple utils tests from core * Add changeset --------- Co-authored-by: Dimitris Grigoriou <[email protected]> Co-authored-by: ferglor <[email protected]> Co-authored-by: Jordan Krage <[email protected]> Co-authored-by: Patrick <[email protected]> Co-authored-by: Cedric <[email protected]> Co-authored-by: Bolek <[email protected]> Co-authored-by: Chunkai Yang <[email protected]> Co-authored-by: Bartek Tofel <[email protected]> Co-authored-by: Erik Burton <[email protected]>
* Bump version and update CHANGELOG for core v2.12.0 Signed-off-by: Sneha Agnihotri <[email protected]> * core/services: fix ocrWrapper saveError contexts (#13139) (cherry picked from commit 15fab1d) * changed spammy error log to debug (#13153) (cherry picked from commit 3502176) * Updating changelog for 2.12.0 with cherry pick fix Signed-off-by: Sneha Agnihotri <[email protected]> * BCF-3225 - Implement forwarder fallback if forwarder not present as a transmitter on OCR2 aggregator (#13221) * Implement forwarder OCR2 fallback if fwd not present as a transmitter * Add changeset * Fix panic on mercury server error (#13231) (#13256) * Fix changelog * Fixed CPU usage issues caused by inefficiencies in HeadTracker (#13230) * Fixed CPU usage issues caused by inefficiencies in HeadTracker * added comments * revert heads back to the fix (cherry picked from commit 6f1ebca) * Update CHANGELOG for 2.12.0 bugfixes Signed-off-by: Sneha Agnihotri <[email protected]> * Decouple ChainType from config string [SHIP-2001] (#13272) * fix: Decouple ChainType from config string * fix: receiver name and failing test * test: enhance config test to test for xdai specifically * refactor: directly unmarshal into ChainType * fix: validation * test: fix TestDoc/EVM * test: add xdai to warnings.xtar * Index only the fifth word to reduce the db size overhead (#13315) Co-authored-by: Domino Valdano <[email protected]> * Add special transmitter for OCR2 feeds (#13323) * Add special transmitter for OCR2 feeds * Add ocr2FeedsTransmitter FromAddress() * Cherry-pick some forwarders context changes from (#13171) * Improve ocr2FeedsTransmitter FromAddress() fallback (#13343) * Improve ocr2FeedsTransmitter FromAddress() fallback * Fix forwarders test error assert * Update 2.12.0 Changelog with bugfixes Signed-off-by: Sneha Agnihotri <[email protected]> * core/services/pipeline: bridge task must continue after cancellation * core/services/pipeline: use request context for deletion (#13404) * core/services/pipeline: hide deadline from monitor * Finalize date on changelog for 2.12.0 Signed-off-by: Sneha Agnihotri <[email protected]> * Fix merge conflicts * Remove `overtimeThresholds` * Return to old version of pipeline-runner --------- Signed-off-by: Sneha Agnihotri <[email protected]> Co-authored-by: Jordan Krage <[email protected]> Co-authored-by: Patrick <[email protected]> Co-authored-by: ilija42 <[email protected]> Co-authored-by: Sam <[email protected]> Co-authored-by: Dmytro Haidashenko <[email protected]> Co-authored-by: Friedemann Fürst <[email protected]> Co-authored-by: Mateusz Sekara <[email protected]> Co-authored-by: Domino Valdano <[email protected]> Co-authored-by: ilija <[email protected]> Co-authored-by: frank zhu <[email protected]> Co-authored-by: george-dorin <[email protected]>
1c576d0 added more logs. At https://github.com/smartcontractkit/chainlink/blame/be50a8370a0f604fbe9612e38479ccfa5ceb1ebd/core/services/pipeline/runner.go#L416 we add all errors to fatal errors by default. With the linked commit, we now log all fatal errors, so now all errors are counted as fatal and logged at the Error level.
ErrCanceled
is such an error that does not need to be logged at the Error level. Changed to debug level.