KS-205: add workflow name to spec #13265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krehermann
force-pushed
the
ks-205/workflow-name
branch
from
1a4faab to
fef2c56
Compare
krehermann
force-pushed
the
ks-205/workflow-name
branch
from
fef2c56 to
23670e3
Compare
bolekk
reviewed
May 21, 2024
ettec
previously approved these changes
May 21, 2024
krehermann
force-pushed
the
ks-205/workflow-name
branch
from
5b8e953 to
3e8e399
Compare
DeividasK
reviewed
May 21, 2024
krehermann
force-pushed
the
ks-205/workflow-name
branch
from
a7c4a45 to
c33f8ca
Compare
bolekk
previously approved these changes
May 21, 2024
| @@ -78,6 +78,8 @@ type ORM interface { | |||
|
|
|||
| DataSource() sqlutil.DataSource | |||
| WithDataSource(source sqlutil.DataSource) ORM | |||
|
|
|||
| FindJobIDByWorkflow(ctx context.Context, spec WorkflowSpec) (int32, error) | |||
There was a problem hiding this comment.
nit: a fully-descriptive name would be FindJobByWorkflowNameAndOwner but it's annoyingly long.
bolekk
previously approved these changes
May 22, 2024
bolekk
approved these changes
May 23, 2024
|
DeividasK
approved these changes
May 23, 2024
This was referenced May 23, 2024
cedric-cordenier
pushed a commit
that referenced
this pull request
May 29, 2024
* KS-205: add workflow name to spec * fix test * fix sql and test * fix tests * remove empty wf owner,name check * fix bad merge of main * rename migration --------- Co-authored-by: Bolek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds WorkflowName to the spec
This in turn is used on the node to ensure that (owner, name) are unique, which is important for job management.