Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ocr2vrf #13472

Merged
merged 12 commits into from
Jul 3, 2024
Merged

Remove ocr2vrf #13472

merged 12 commits into from
Jul 3, 2024

Conversation

vreff
Copy link
Contributor

@vreff vreff commented Jun 9, 2024 •
edited
Loading

Removes ocr2vrf and dkg OCR2 plugin materials.

vreff
vreff commented Jun 9, 2024
View reviewed changes
core/services/ocr2/delegate.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 10, 2024 •
edited
Loading

I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found - Please include it in the PR title or in a commit message.

@reductionista
Copy link
Contributor

LGTM, just need to resolve the merge conflict

@vreff vreff requested a review from dkneisly June 10, 2024 15:49
jinhoonbang
jinhoonbang previously approved these changes Jun 25, 2024
View reviewed changes
core/services/synchronization/telemetry_ingress_batch_client_test.go
Telemetry: []byte("Mock telem 2"),
ContractID: "0x2",
TelemType: synchronization.OCR2VRF,
}
telemPayload3 := synchronization.TelemPayload{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*nit can rename to telemPayload2 now

@vreff vreff marked this pull request as ready for review July 3, 2024 21:15
@vreff vreff requested review from a team and RensR as code owners July 3, 2024 21:15
@vreff vreff added this pull request to the merge queue Jul 3, 2024
Merged via the queue into develop with commit 685681e Jul 3, 2024
113 of 114 checks passed
@vreff vreff deleted the remove-ocr2vrf branch July 3, 2024 21:44
@github-actions github-actions bot mentioned this pull request Jul 3, 2024
Draft
@github-actions github-actions bot mentioned this pull request Jul 18, 2024
Closed
@chainchad chainchad mentioned this pull request Jul 29, 2024
Merged
This was referenced Jul 31, 2024
Draft
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinhoonbang jinhoonbang jinhoonbang approved these changes

@reductionista reductionista reductionista approved these changes

@makramkd makramkd Awaiting requested review from makramkd

@FelixFan1992 FelixFan1992 Awaiting requested review from FelixFan1992

@justinkaseman justinkaseman Awaiting requested review from justinkaseman

@kidambisrinivas kidambisrinivas Awaiting requested review from kidambisrinivas

@ibrajer ibrajer Awaiting requested review from ibrajer

@iljapavlovs iljapavlovs Awaiting requested review from iljapavlovs

@dkneisly dkneisly Awaiting requested review from dkneisly

@RensR RensR Awaiting requested review from RensR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vreff @reductionista @jinhoonbang