zkSync L1 gas Price calculation oracle #13498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matYang
previously approved these changes
Jun 12, 2024
| return | ||
| } | ||
|
|
||
| // For zkSync l1_price_per_pubdata ~= gas_price_on_l2 * l2_gas_PerPubdataByte |
There was a problem hiding this comment.
nit: explicitly specify is it per byte, like l1_price_per_pubdata_byte, as opposed to pubdata gas or slot
amit-momin
reviewed
Jun 12, 2024
amit-momin
approved these changes
Jun 12, 2024
FelixFan1992
approved these changes
Jun 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
matYang
approved these changes
Jun 12, 2024
This was referenced Jun 12, 2024
asoliman92
pushed a commit
that referenced
this pull request
Jul 31, 2024
* zkSync L1 Oracle gas Price * fix tests & issues * addressed comments * added changeset * Addressed comments
asoliman92
pushed a commit
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZkSync L1 Gas price calculation by multiplying gasPerPubDataByte * L2GasPrice