move v2_3 out of dev folder #13504
Merged
move v2_3 out of dev folder #13504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RensR
reviewed
Jun 11, 2024
contracts/package.json
Outdated
| @@ -18,7 +18,7 @@ | |||
| "prepublishOnly": "pnpm compile && ./scripts/prepublish_generate_abi_folder", | |||
| "publish-beta": "pnpm publish --tag beta", | |||
| "publish-prod": "pnpm publish --tag latest", | |||
| "solhint": "solhint --max-warnings 2 \"./src/v0.8/**/*.sol\"" | |||
| "solhint": "solhint --max-warnings 3 \"./src/v0.8/**/*.sol\"" | |||
There was a problem hiding this comment.
Fix the issue, don't increment the counter. If the behaviour is desired add a solhint ignore line
There was a problem hiding this comment.
I just reverted it back. This change was not needed as the solhint issues was on our I*RegistryMaster.sol, which should ignore solhint check (https://github.com/smartcontractkit/chainlink/pull/13504/files#diff-bf3ee5318018ff95ee8303e7d1ed0c0855a9520d003ba32928266ec74e915e0d). So this line of change is not needed at all. I just changed it back
FelixFan1992
approved these changes
Jun 12, 2024
RyanRHall
approved these changes
Jun 12, 2024
This was referenced Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AUTO-11039