Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support "dummy" relayer type #13583

Merged
merged 7 commits into from
Jun 25, 2024
Merged

Support "dummy" relayer type #13583

merged 7 commits into from
Jun 25, 2024

Conversation

samsondav
Copy link
Collaborator

@samsondav samsondav commented Jun 17, 2024 •
edited
Loading

This allows testing of plugins without needing a real connection to any chain.
Ticket: https://smartcontract-it.atlassian.net/browse/MERC-5574

@samsondav samsondav force-pushed the MERC-5574-new-relayer-type-dummy-that-accepts-hardcoded-values-for-everything-and-doesnt-do-any-on-chain-stuff branch from d880f6b to ce90014 Compare June 17, 2024 20:40
@samsondav samsondav force-pushed the MERC-5574-new-relayer-type-dummy-that-accepts-hardcoded-values-for-everything-and-doesnt-do-any-on-chain-stuff branch from df7ac83 to 8156b85 Compare June 24, 2024 13:50
@samsondav samsondav marked this pull request as ready for review June 24, 2024 13:52
@samsondav samsondav force-pushed the MERC-5574-new-relayer-type-dummy-that-accepts-hardcoded-values-for-everything-and-doesnt-do-any-on-chain-stuff branch from 8156b85 to 30e9314 Compare June 24, 2024 13:52
@samsondav samsondav requested a review from a team June 24, 2024 13:52
@samsondav samsondav requested review from a team as code owners June 24, 2024 13:52
@samsondav samsondav changed the title MERC 5574 new relayer type dummy that accepts hardcoded values for everything and doesnt do any on chain stuff Support "dummy" relayer type Jun 24, 2024
@samsondav samsondav force-pushed the MERC-5574-new-relayer-type-dummy-that-accepts-hardcoded-values-for-everything-and-doesnt-do-any-on-chain-stuff branch from 30e9314 to 94b4dea Compare June 24, 2024 13:56
@samsondav samsondav force-pushed the MERC-5574-new-relayer-type-dummy-that-accepts-hardcoded-values-for-everything-and-doesnt-do-any-on-chain-stuff branch from 94b4dea to bdfe261 Compare June 24, 2024 14:01
@samsondav samsondav force-pushed the MERC-5574-new-relayer-type-dummy-that-accepts-hardcoded-values-for-everything-and-doesnt-do-any-on-chain-stuff branch from bdfe261 to b1f2052 Compare June 24, 2024 14:27
@samsondav samsondav force-pushed the MERC-5574-new-relayer-type-dummy-that-accepts-hardcoded-values-for-everything-and-doesnt-do-any-on-chain-stuff branch from b1f2052 to 84a7e74 Compare June 24, 2024 14:28
@samsondav samsondav force-pushed the MERC-5574-new-relayer-type-dummy-that-accepts-hardcoded-values-for-everything-and-doesnt-do-any-on-chain-stuff branch from 84a7e74 to 287284f Compare June 24, 2024 14:50
@samsondav samsondav force-pushed the MERC-5574-new-relayer-type-dummy-that-accepts-hardcoded-values-for-everything-and-doesnt-do-any-on-chain-stuff branch from 4a7ea78 to 02cba36 Compare June 24, 2024 15:00
jmank88
jmank88 reviewed Jun 24, 2024
View reviewed changes
core/services/relay/relay.go Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this set still need to be updated? The unmarshaller doesn't require the value to be in this set anymore.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah apparently so, there was a test failing if I didn't add this

@samsondav samsondav requested a review from jmank88 June 24, 2024 15:38
austinborn
austinborn reviewed Jun 25, 2024
View reviewed changes
core/services/ocr2/delegate.go
@@ -895,9 +895,6 @@ func (d *Delegate) newServicesLLO(
if err != nil {
return nil, ErrJobSpecNoRelayer{Err: err, PluginName: "streams"}
}
if rid.Network != relay.NetworkEVM {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to double-check, you don't need this log anymore?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a check, not a log if I'm not mistaken, and there isn't really any reason for it to be here. LLO should support any relayer type.

austinborn
austinborn previously approved these changes Jun 25, 2024
View reviewed changes
@samsondav samsondav force-pushed the MERC-5574-new-relayer-type-dummy-that-accepts-hardcoded-values-for-everything-and-doesnt-do-any-on-chain-stuff branch from 5c76938 to 92a5f35 Compare June 25, 2024 13:20
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
1 New issue
1 Fixed issue
0 Accepted issues

Measures
0 Security Hotspots
69.8% Coverage on New Code
8.8% Duplication on New Code

See analysis details on SonarQube

@samsondav samsondav enabled auto-merge June 25, 2024 13:42
@samsondav samsondav added this pull request to the merge queue Jun 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 25, 2024
@samsondav samsondav added this pull request to the merge queue Jun 25, 2024
Merged via the queue into develop with commit 8ccaa14 Jun 25, 2024
112 of 113 checks passed
@samsondav samsondav deleted the MERC-5574-new-relayer-type-dummy-that-accepts-hardcoded-values-for-everything-and-doesnt-do-any-on-chain-stuff branch June 25, 2024 16:59
@github-actions github-actions bot mentioned this pull request Jun 25, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krehermann krehermann krehermann approved these changes

@austinborn austinborn austinborn approved these changes

@jmank88 jmank88 Awaiting requested review from jmank88

@prashantkumar1982 prashantkumar1982 Awaiting requested review from prashantkumar1982

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samsondav @jmank88 @austinborn @krehermann @prashantkumar1982