Allow flat interpolation #13601
Merged
Allow flat interpolation #13601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-cordenier
force-pushed
the
allow-flat-interpolation
branch
3 times, most recently
from
b3180db to
ffa5155
Compare
cedric-cordenier
force-pushed
the
allow-flat-interpolation
branch
from
ffa5155 to
1b01270
Compare
cedric-cordenier
force-pushed
the
allow-flat-interpolation
branch
from
1b01270 to
d226d76
Compare
bolekk
reviewed
Jun 22, 2024
| require.NoError(t, err) | ||
| assert.Equal(t, "aValue1", responseValue.(string)) | ||
| assert.Equal(t, "aValue1", mp.(map[string]any)["response"].(string)) |
There was a problem hiding this comment.
I don't get it. Where do we create this nested "response" key in the map? Is it now a requirement for every capability?
There was a problem hiding this comment.
I've tagged you where we add the response key.
The only requirement this PR introduces is for capabilities to return a map, not just any value. I think this is preferable because a) all capabilities so far return a map anyway, and b) it's symmetric with the inputs we expect
| @@ -409,8 +409,12 @@ func (t TestCapability) Execute(ctx context.Context, request commoncap.Capabilit | |||
|
|
|||
| value := request.Inputs.Underlying["executeValue1"] | |||
|
|
|||
| response, err := values.NewMap(map[string]any{"response": value}) | |||
There was a problem hiding this comment.
@bolekk This is where we create the response value
cedric-cordenier
force-pushed
the
allow-flat-interpolation
branch
from
f177173 to
31a8e13
Compare
cedric-cordenier
force-pushed
the
allow-flat-interpolation
branch
from
bd617b0 to
1f096fb
Compare
ilija42
previously approved these changes
Jun 27, 2024
ettec
previously approved these changes
Jun 27, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
ettec
approved these changes
Jun 27, 2024
ilija42
approved these changes
Jun 27, 2024
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Requires Dependencies
inputschainlink-common#540Resolves Dependencies