evm: Pass value param to the txm #13602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickcorin
requested review from
archseer,
patrick-dowell,
silaslenihan and
ilija42
ilija42
reviewed
Jun 18, 2024
| @@ -111,6 +111,11 @@ func (w *chainWriter) SubmitTransaction(ctx context.Context, contract, method st | |||
| checker.CheckerType = txmgrtypes.TransmitCheckerType(methodConfig.Checker) | |||
| } | |||
|
|
|||
| v := big.NewInt(0) | |||
There was a problem hiding this comment.
why is txmgr accepting big.Int without a pointer 😫
There was a problem hiding this comment.
We're busy discussing whether it's in scope to edit this too along with the other big.Int -> *big.Int changes we're making.
There was a problem hiding this comment.
But there is an argument that nil is not a valid tx value and using big.Int helps prevent accidental panics at the cost of being a little ugly.
ilija42
previously approved these changes
Jun 18, 2024
ilija42
approved these changes
Jun 18, 2024
|
patrick-dowell
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Requires Dependencies
Resolves Dependencies