[TT-1345] option to use predeployed contracts in OCR tests #13758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chudilka1
reviewed
Jul 8, 2024
Tofel
force-pushed
the
tt_1345_predeployed_contracts_ocr_tests
branch
from
2b5d0d4 to
09960cf
Compare
lukaszcl
reviewed
Sep 2, 2024
lukaszcl
reviewed
Sep 2, 2024
| time.Sleep(2 * time.Second) | ||
| } else { | ||
| // Load contract wrappers | ||
| for _, address := range ocrContractsConfig.OffChainAggregatorsContractsAddresses() { |
There was a problem hiding this comment.
@Tofel, out of curiosity, why do we use an interface like OffChainAggregatorsConfig? Wouldn’t it be simpler to use config methods or fields directly?
There was a problem hiding this comment.
I have some logic underneath that returns empty array if contracts are disabled on some level. That way the caller doesn't have to know anything about that logic.
|
Please stop mentioning me in these tickets and spamming my notifications, thank you. |
davidcauchi
previously approved these changes
Sep 11, 2024
gheorghestrimtu
previously approved these changes
Sep 19, 2024
davidcauchi
previously approved these changes
Sep 19, 2024
Tofel
dismissed stale reviews from davidcauchi and gheorghestrimtu
via
87f10b9
gheorghestrimtu
approved these changes
Sep 19, 2024
lukaszcl
approved these changes
Sep 19, 2024
momentmaker
added a commit
that referenced
this pull request
Sep 19, 2024
…tractkit/chainlink into re-2964/goreleaser-ccip * 're-2964/goreleaser-ccip' of https://github.com/smartcontractkit/chainlink: Fix data race in TestLogPoller_Replay (#14431) Fix CCIP Load Test Faulty Fund Return (#14499) use tx in insertLogsWithinTx (#14361) Bring KMS client and multiclient over to chainlink (#14484) CCIP-3420: Fix IsRequestTriggeredWithinTimeframe (#1445) (#14498) [TT-1345] option to use predeployed contracts in OCR tests (#13758) CCIP-3428 Enabling ccip smoke test for testnet (#14452)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to use existing LINK token and OCRv1 / OCRv2 contracts in OCR soak/smoke & load tests. It allows to specify number of OCR contracts to deploy as well as deciding whether existing contracts should be use as-is or whether they should be configured.
This functionality is crucial for testing OCR on chains like zkSync, where we cannot deploy contracts using our testing code, but we can do it using other tools. Since interaction with zkSync contracts is possible using geth wrappers we can execute test logic there.
Tests executed:
New contract number configuration format:
In nutshell: previously we could configure number of contracts only for Soak tests, now we can configure it for ALL tests, because it's no longer tightly coupled to test type.