Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix write target nil dereferences #14059

Merged
merged 44 commits into from
Aug 8, 2024
Merged

Fix write target nil dereferences #14059

merged 44 commits into from
Aug 8, 2024

Conversation

DeividasK
Copy link
Collaborator

No description provided.

DeividasK and others added 30 commits August 2, 2024 17:20
@DeividasK
Hardcoded value for call with exact gas
760f669
@DeividasK
Record gasProvided in route function
5d60ce6
@DeividasK
Add a getter for transmission gas limit
92a7dfd
@DeividasK
Update snapshot
afb4a0f
@DeividasK
Changeset
ceceb23
@DeividasK
Remove unused import
e2a5b03
@DeividasK
Rename to gas limit
a502356
@DeividasK
Merge a502356 into f5e0bd6
5d761e2
@app-token-issuer-infra-releng
Update gethwrappers
9eaf2b7
@DeividasK
Uncomment test code
62b603a
@DeividasK
Remove copy/pasta comment
4a806bb
@DeividasK
Slight rename
709bf11
@DeividasK
Allow retrying transmissions with more gas
4953204
@DeividasK
Only allow retrying failed transmissions
c19c0fb
@DeividasK
Update snapshot
d7f6197
@DeividasK
Fix state for InvalidReceiver check
2098cd4
@DeividasK
Check for initial state
3482743
@DeividasK
Actually store gas limit provided to receiver
563dde4
@DeividasK
Merge 563dde4 into 7ec99ef
1400bb5
@app-token-issuer-infra-releng
Update gethwrappers
7aac6c5
@DeividasK
Remove unused struct
0c40708
@DeividasK
Correctly mark invalid receiver when receiver interface unsupported
b92489e
@DeividasK
Create TransmissionInfo struct
41183bd
@DeividasK
Merge 41183bd into d90bb66
8cd14df
@app-token-issuer-infra-releng
Update gethwrappers
e302839
@DeividasK
Bump gas limit
d27fc3d
@DeividasK
Bump gas even more
16ffae5
@DeividasK
Update KeystoneFeedsConsumer.sol to implement IERC165
78a345e
@DeividasK
Use getTransmissionInfo
04f760b
@DeividasK
Use TransmissionState to determine if transmission should be created
ff6f229
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

I see you updated files related to contracts. Please run pnpm changeset in the contracts directory to add a changeset.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024 •
edited
Loading

LCOV of commit dc9caeb during Solidity Foundry #41052

Summary coverage rate:
  lines......: 98.7% (1838 of 1862 lines)
  functions..: 96.6% (344 of 356 functions)
  branches...: 90.7% (782 of 862 branches)

Files changed coverage rate: n/a

Base automatically changed from dk-call-with-exact-gas to develop August 8, 2024 02:52
@DeividasK DeividasK marked this pull request as ready for review August 8, 2024 05:30
@DeividasK DeividasK requested a review from a team as a code owner August 8, 2024 05:30
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@archseer archseer added this pull request to the merge queue Aug 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 8, 2024
@DeividasK DeividasK added this pull request to the merge queue Aug 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 8, 2024
@DeividasK DeividasK added this pull request to the merge queue Aug 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 8, 2024
@DeividasK DeividasK added this pull request to the merge queue Aug 8, 2024
Merged via the queue into develop with commit 40f4bec Aug 8, 2024
120 checks passed
@DeividasK DeividasK deleted the dk-fix-write-target-nil-dereference branch August 8, 2024 14:43
@github-actions github-actions bot mentioned this pull request Aug 8, 2024
Draft
momentmaker added a commit that referenced this pull request Aug 8, 2024
@momentmaker
Merge branch 'develop' into re-2756/goreleaser-build-image
4d17c65 
* develop:
  CRIB CI integration (#13924)
  fix: refactor sonarqube scan args (#13875)
  BCI-3492 [LogPoller]: Allow withObservedExecAndRowsAffected to report non-zero rows affected (#14057)
  Add error mapping for Astar (#13990)
  [BCI-3862][chainlink] - Change DSL Block primitive to string instead of int (#14033)
  [KS-412] Validate called DON membership in TriggerPublisher (#14040)
  [TT-1429] notifying guardian on some failures (#14073)
  Add Mantle errors (#14053)
  Fix write target nil dereferences (#14059)
  Allow retrying failed transmissions (#14017)
  auto-11214: migrate more tests to foundry (#13934)
This was referenced Aug 18, 2024
Draft
Draft
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedric-cordenier cedric-cordenier cedric-cordenier approved these changes

@archseer archseer archseer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DeividasK @archseer @cedric-cordenier