Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hedera int with TXM fixes & config #14129

Merged
merged 17 commits into from
Sep 20, 2024
Merged

Hedera int with TXM fixes & config #14129

merged 17 commits into from
Sep 20, 2024

Conversation

simsonraj
Copy link
Contributor

Requires Dependencies

Resolves Dependencies

@simsonraj simsonraj requested a review from a team as a code owner August 15, 2024 08:49
@simsonraj simsonraj requested a review from a team as a code owner August 15, 2024 08:59
docs/CONFIG.md Outdated Show resolved Hide resolved
LogPollInterval = '10s'
MinIncomingConfirmations = 1
#turning off the liveness detection, since the Websocket connection is not reliable, can be turned on if needed
NoNewHeadsThreshold = '0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhaidashenko : Does this comment and setting look good?
If Hedera has a 2 second block rate, we assume heads to come regularly.
Websock not being reliable doesn't seem to imply we should set this to 0.

Also, how close are we to doing liveness checks via Polling?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HeadTracker uses websocket connection to get new heads. If there is no new heads, TXM's confirmer won't mark txs as confirmed and will eventually get stuck. It's highly recommended to enable this check, especially if the ws connection is not reliable. It will force to create a new connection, thus we'll have a chance to auto resolve the issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have only 1 working RPC, we cannot mark that as out-of-sync, especially with un-reliable Websocket endpoints, we set it to zero, so it waited till auto recovered, this again will be switched back on once we get 2 more fully functioning RPC

core/chains/evm/config/toml/defaults/Hedera_Mainnet.toml Outdated Show resolved Hide resolved


[NodePool]
#Disabling sync threshold check for testing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this was disabled for testing. Should be set it to something meaningful now?

@dhaidashenko ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's better to set it to something meaningful now. If we are running on single RPC it won't affect it's health.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again with single RPC & unreliable sync times, setting this throws a lot of error & warning & marks it out-of-sync.
Rather than setting this to a really high number, we disabled it until we get more stable RPCs to work with

@davidcauchi davidcauchi requested review from a team as code owners September 5, 2024 09:05
@cl-sonarqube-production
Copy link

@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Sep 20, 2024
Merged via the queue into develop with commit 85a8d09 Sep 20, 2024
74 of 76 checks passed
@prashantkumar1982 prashantkumar1982 deleted the hedera_int branch September 20, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants