Create an empty registry if external registry is not connected #14174
Conversation
…al-registry # Conflicts: # go.mod # go.sum
| @@ -199,3 +200,30 @@ func NewRegistry(lggr logger.Logger) *Registry { | |||
| lggr: lggr.Named("CapabilitiesRegistry"), | |||
| } | |||
| } | |||
|
|
|||
| // TestMetadataRegistry is a test implementation of the metadataRegistry | |||
There was a problem hiding this comment.
nit: I don't think it should be called "Test", maybe "Dummy" or "Default" or something similiar
There was a problem hiding this comment.
I agree with your sentiment. I had this discussion with @cedric-cordenier, too. Given that I am using it for testing at the moment and we don't have a clear product need, Test seems "calling it what it is".
| golang.org/x/sync v0.7.0 | ||
| golang.org/x/term v0.22.0 | ||
| golang.org/x/text v0.16.0 | ||
| golang.org/x/crypto v0.26.0 |
There was a problem hiding this comment.
This is what showed up after go get github.com/smartcontractkit/chainlink-common@<hash> && make gomodtidy, so I assume so 🤷♂️
There was a problem hiding this comment.
Ah, these are from Ryan bumping the deps for the generators (in common)
| Members: []p2ptypes.PeerID{ | ||
| peerID, | ||
| }, | ||
| F: 0, |
There was a problem hiding this comment.
I hope this won't cause any validation issues down the line. Are we ever going to look at these values in other componenets?
There was a problem hiding this comment.
Are we ever going to look at these values in other components?
Not planned atm.
There was a problem hiding this comment.
Ah it would be nice if this was configurable: I need f = 1 for e2e testing
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@DeividasK you have to update the branch and merge develop. Otherwise PR will be kicked out of merge queue due to recent changes to CI on develop. |
| @@ -33,8 +33,8 @@ require ( | |||
| github.com/slack-go/slack v0.12.2 | |||
| github.com/smartcontractkit/chain-selectors v1.0.21 | |||
| github.com/smartcontractkit/chainlink-automation v1.0.4 | |||
| github.com/smartcontractkit/chainlink-common v0.2.2-0.20240816204408-654165b6ee33 | |||
| github.com/smartcontractkit/chainlink-testing-framework v1.34.5 | |||
There was a problem hiding this comment.
@DeividasK please use chainlink-testing-framework v1.34.5. I'm not sure about chainlink-common v0.2.2-0.20240816204408-654165b6ee33. Do you have any reasons to use a different version for it? Also, once you update the mods in integration-tests/ then please do:
cd integration-tests/
go mod tidy
and
cd integration-tests/load
go mod tidy
There was a problem hiding this comment.
I'm not sure about chainlink-common v0.2.2-0.20240816204408-654165b6ee33. Do you have any reasons to use a different version for it?
Yes, the latest version has the changes that fix keystone integration tests.
DeividasK
force-pushed
the
dk-cc-empty-external-registry
branch
from
18ff39e to
7545bb6
Compare
|
Paired with @cedric-cordenier