Implement v0.3-compatible telemetry for LLO #14440
Conversation
samsondav
force-pushed
the
MERC-3603-llo-implement-telemetry
branch
2 times, most recently
from
0ee70dd to
606aaac
Compare
|
I see you updated files related to
|
samsondav
force-pushed
the
MERC-3603-llo-implement-telemetry
branch
from
df05b50 to
2904fb5
Compare
| } | ||
|
|
||
| func (t *telemeter) collectV3PremiumLegacyTelemetry(d TelemetryObservation) { | ||
| eaTelemetryValues := ocrcommon.ParseMercuryEATelemetry(t.eng.SugaredLogger, d.trrs, mercuryutils.REPORT_V3) |
There was a problem hiding this comment.
Are we going to have to support v4 here? I'm happy to add the support if so.
There was a problem hiding this comment.
Parallel comp does not support v4 at this time. We will need an additional piece of work in Q4 to add that.
core/services/llo/telemetry.go
Outdated
| return newTeleter(lggr, monitoringEndpoint) | ||
| } | ||
|
|
||
| func newTeleter(lggr logger.Logger, monitoringEndpoint commontypes.MonitoringEndpoint) *telemeter { |
core/services/ocrcommon/telemetry.go
Outdated
There was a problem hiding this comment.
@samsondav is the concept of feedID going away for llo? I see that Feed: e.job.OCR2OracleSpec.FeedID.Hex(), is still a line in the EaTelem.
There was a problem hiding this comment.
Parallel comp sends the stream ID in place of the feed ID
|
| errmu.Unlock() | ||
| return | ||
| } | ||
|
|
||
| d.t.EnqueueV3PremiumLegacy(run, trrs, streamID, opts, val, nil) |
There was a problem hiding this comment.
How using the streamID impacts the current usage of telemetry data since it does not relate anymore with the feed (channel) ?
There was a problem hiding this comment.
We want to monitor streams not channels since channels can contain multiple streams, which does not map properly to the telemetry packets.
This is just one of those impedance mismatches. We are trying to force a channel/stream paradigm into the old feed telemetry structure.
The real solution is to change the telemetry packets and report solely stream values, forgetting feeds entirely, but we can't do that without breaking compatibility right now.
| @@ -210,7 +210,6 @@ func TestIntegration_LLO(t *testing.T) { | |||
| } | |||
| serverURL := startMercuryServer(t, srv, clientPubKeys) | |||
|
|
|||
| // TODO: all args? | |||
| steve, backend, configurator, configuratorAddress, verifier, _, verifierProxy, _, configStore, configStoreAddress := setupBlockchain(t) | |||
* develop: (79 commits) core/config/toml: include value in InsecureConnection error message (#14495) vrf: add soneium config for integration tests (#14443) Add default test config for Grafana (#14475) Update to 1.5 RMN contract address (#14485) fix lint issues (#14450) [BCFR-203] Improve CR value comparator querying (topics and data words) by doing encoding in the relayer (#14207) integration-tests/deployment/ccip: fix assertion fns (#14482) chore: remove gha workflow validation (#14487) devsvcs-244: update token transfer (#14481) DF-20481: Add new OCR3DataFeeds telemetry type for Mercury jobs (#14470) Merc 6304 view function ea telem support (#14467) [DEVSVCS-545] cleanup (#14478) Mantle use vanilla l1 oracle (#14471) Fix E2E_TESTS_ON_GITHUB_CI.md (#14473) Upgrade chainlink ccip dependency (#14474) [DEVSVCS-545] automation benchmark test remove support for keepers v1 (#14472) Enables OOO Execution for E2E Tests (#14392) Delegate workflow spec creation (#14365) CCIP-3407: Add release testing configs (#1436) (#14463) Implement v0.3-compatible telemetry for LLO (#14440) ...
Requires
Resolves