implement HTTP target capability and connector handler #14491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinhoonbang
requested review from
vyzaldysanchez,
DavidOrchard,
bolekk,
cedric-cordenier and
justinkaseman
and removed request for
a team and
vyzaldysanchez
MStreet3
reviewed
Sep 20, 2024
MStreet3
reviewed
Sep 20, 2024
MStreet3
reviewed
Sep 20, 2024
MStreet3
reviewed
Sep 20, 2024
MStreet3
reviewed
Sep 20, 2024
MStreet3
reviewed
Sep 20, 2024
MStreet3
reviewed
Sep 20, 2024
MStreet3
reviewed
Sep 20, 2024
| type WorkflowConfig struct { | ||
| TimeoutMs uint32 `json:"timeoutMs,omitempty"` // Timeout in milliseconds | ||
| RetryCount uint8 `json:"retryCount,omitempty"` // Number of retries, defaults to 0. | ||
| Schedule string `json:"schedule,omitempty"` // schedule, defaults to empty. |
There was a problem hiding this comment.
Description doesn't say what this is.
Also, nit: not sure if schedule is the most accurate name for this. More like a strategy/type/method.
There was a problem hiding this comment.
how about DeliveryMode ?
There was a problem hiding this comment.
Yeah that sounds good
jinhoonbang
requested review from
DavidOrchard,
justinkaseman and
cedric-cordenier
| } | ||
|
|
||
| func NewCapability(config Config, registry core.CapabilitiesRegistry, connectorHandler *ConnectorHandler, lggr logger.Logger) (*Capability, error) { | ||
| return &Capability{ |
There was a problem hiding this comment.
nit: only fix if doing other fixes, but how about validating some of the fields? Says connectorHandler is nil?
| return capabilities.CapabilityResponse{}, err | ||
| } | ||
|
|
||
| // TODO: check target response format and fields |
There was a problem hiding this comment.
yep linked a JIRA ticket
|
|
||
| func (c *Capability) RegisterToWorkflow(ctx context.Context, req capabilities.RegisterToWorkflowRequest) error { | ||
| // Workflow engine guarantees registration requests are valid | ||
| // TODO: handle retry configuration |
There was a problem hiding this comment.
nit: link to jira that will resolve the todo.
|
DavidOrchard
approved these changes
Sep 25, 2024
cedric-cordenier
approved these changes
Sep 26, 2024
cedric-cordenier
deleted the
target-capability-and-connector-handler
branch
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SingleNodemode, which forwards HTTP calls via the first available gateway. This is done through a newSignAndSendToGateway()method in the gateway connector that selects an available gateway and signs the request before sending it to the gatewaycapability.Execute()JIRA: https://smartcontract-it.atlassian.net/browse/CM-469
Doc: https://docs.google.com/document/d/19PvTwosdwqNztwP6vcXSdt_s81xZXpjKU-5bpwhsd2M/edit#heading=h.4e7ng0tekbkc