Bump chainlink-solana #14575
Merged
Bump chainlink-solana #14575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WF: CI Core#51b134bNo errors found in this run. 🎉 |
… into BCFR-960-bump-chainlink-solana
dhaidashenko
reviewed
Oct 3, 2024
…martcontractkit/chainlink into BCFR-960-bump-chainlink-solana
|
aalu1418
approved these changes
Oct 7, 2024
jmank88
requested changes
Oct 7, 2024
| SyncThreshold = 5 # Default | ||
| # NodeIsSyncingEnabled enables the feature to avoid sending transactions to nodes that are syncing. Not relavant for Solana. | ||
| NodeIsSyncingEnabled = false # Default | ||
| # LeaseDuration is the max duration a node can be leased for. |
There was a problem hiding this comment.
Can we please do another pass on these docs? Phrases like this are skirting the documentation requirement by saying nothing in particular, and in this case we already have good EVM examples to draw on.
There was a problem hiding this comment.
I merged to unblock other PRs, but please circle back to this.
There was a problem hiding this comment.
Yeah sounds good, I'll create a ticket for later!
jmank88
approved these changes
Oct 7, 2024
This was referenced Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump chainlink-solana and fix tests which broke due to new TOML configuration being added for Solana MultiNode.
Ticket: https://smartcontract-it.atlassian.net/browse/BCFR-960
Resolves
https://smartcontract-it.atlassian.net/browse/BCFR-960