Dynamic fee types cleanup #14602
Merged
Dynamic fee types cleanup #14602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amit-momin
reviewed
Sep 30, 2024
amit-momin
previously approved these changes
Oct 1, 2024
Farber98
previously approved these changes
Oct 2, 2024
huangzhen1997
previously approved these changes
Oct 2, 2024
patrick-dowell
previously approved these changes
Oct 3, 2024
dimriou
dismissed stale reviews from amit-momin, Farber98, huangzhen1997, and patrick-dowell
via
3c4acdb
WF: CI Core#3936f1eNo errors found in this run. 🎉 |
dimkouv
previously approved these changes
Oct 8, 2024
jmank88
reviewed
Oct 8, 2024
|
|
||
| // HexToInt64 performs the inverse of Int64ToHex | ||
| // Returns 0 on invalid input | ||
| func HexToInt64(input interface{}) int64 { |
There was a problem hiding this comment.
Here and a few other places in BHE. I just moved them, nothing new was added.
There was a problem hiding this comment.
Do they need to be exported?
jmank88
reviewed
Oct 8, 2024
amit-momin
previously approved these changes
Oct 8, 2024
|
jmank88
approved these changes
Oct 8, 2024
FelixFan1992
approved these changes
Oct 8, 2024
amit-momin
approved these changes
Oct 8, 2024
dimkouv
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BCFR-965
Update dynamic fees to align with Geth's spec