Support Zircuit fraud transactions and zk overflow detection #14629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n, need dedup and unit test
huangzhen1997
commented
Oct 2, 2024
friedemannf
reviewed
Oct 2, 2024
| @@ -1,5 +1,5 @@ | |||
| ChainID = '48900' | |||
| ChainType = 'optimismBedrock' | |||
| ChainType = 'zircuit' | |||
There was a problem hiding this comment.
Can you also add that for the Sepolia defaults?
amit-momin
reviewed
Oct 2, 2024
amit-momin
reviewed
Oct 2, 2024
amit-momin
reviewed
Oct 2, 2024
|
There are a few more places I think we need to add the new Zircuit chain type |
amit-momin
previously approved these changes
Oct 2, 2024
dimriou
previously approved these changes
Oct 3, 2024
| for i, req := range txReqs { | ||
| txHash := req.Args[0].(common.Hash) | ||
| if req.Error != nil { | ||
| d.lggr.Debugf("failed to check fraud transaction by hash (%s): %v", txHash.String(), req.Error) |
There was a problem hiding this comment.
I don't have any context on the use case for this feature, but... if the node is unable to verify whether transactions are fraudulent, shouldn't it flag an error, or at least warn about it? (Rather than just logging at level="debug"?)
…overflow-detection
reductionista
approved these changes
Oct 4, 2024
|
dimriou
approved these changes
Oct 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
dimriou
deleted the
BCFR-974/support-Zircuit-fraud-tx-and-zk-overflow-detection
branch
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Zircuit has a unique validation that can cause transactions to get stuck in the mempool due to their Sequencer Layer Security (SLS). The chain has provided a custom endpoint zirc_isQuarantined to detect if any transactions have been quarantined for fraud.
Separately, ZK overflows will also be eventually possible so we should use the already built heuristic to detect overflows for when they are introduced.
Acceptance Criteria
The TXM can identify transactions stuck due to fraud detection and purge them with empty transactions
The TXM can identify overflow transactions using the heuristic and purge them with empty transactions
Tickets:
BCFR-974