Broadcast transactions only to a single healthy RPC instead of all #14635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…althy RPCs to avoid redundant relay fees on Hedera
|
amit-momin
approved these changes
Oct 2, 2024
huangzhen1997
approved these changes
Oct 2, 2024
reductionista
approved these changes
Oct 4, 2024
This was referenced Oct 4, 2024
simsonraj
added a commit
that referenced
this pull request
Oct 15, 2024
* Enabling dynamic gas estimation for Hedera (#14601) * turned on hedera gas estimation * added hedera test overrides * enable dynamic gas Limit for Hedera * updated chainlink image (cherry picked from commit 40e9af8) * Broadcast transactions only to a single healthy RPC instead of all (#14635) * Broadcast transactions only to a single healthy RPC instead of all healthy RPCs to avoid redundant relay fees on Hedera * fix tx test (cherry picked from commit ee1d6e3) * Set chainType in chain client (#14719) * Set chain client chainType * Added changeset (cherry picked from commit de9ce67) * solana: add compute unit limit functionality (#14576) * solana: add compute unit limit functionality * fix test: solana node CLI * fix: e2e test artifact upload to container * retry build with fresh commit * changeset * bump solana to merged commit (cherry picked from commit 0e35bc7) --------- Co-authored-by: Dmytro Haidashenko <[email protected]> Co-authored-by: amit-momin <[email protected]> Co-authored-by: Aaron Lu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hedera doesn't have a mempool and has instant finality. Sending the transaction to the first node gets the transaction included so broadcasting to other nodes after leads to nonce too low errors. This normally wouldn't be a problem since these types of errors are usually surfaced upfront by the RPC, but in the case of Hedera, they make it on-chain and the error is only available through receipts which means NOPs have to pay for these transactions.
To avoid this we should only broadcast transactions to a single active RPC.