Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add router to Source/Dest ReaderConfig. #14668

Merged
merged 5 commits into from
Oct 7, 2024
Merged

Add router to Source/Dest ReaderConfig. #14668

merged 5 commits into from
Oct 7, 2024

Conversation

winder
Copy link
Contributor

@winder winder commented Oct 4, 2024 •
edited
Loading

Add configuration for router on source/destination reader.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024 •
edited
Loading

WF: CI Core#82e8898

No errors found in this run. 🎉

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024 •
edited
Loading

WF: CI Core#337de73

No errors found in this run. 🎉

asoliman92
asoliman92 previously approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@asoliman92 asoliman92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@winder winder marked this pull request as ready for review October 7, 2024 14:33
@winder winder requested review from a team as code owners October 7, 2024 14:33
@winder winder enabled auto-merge October 7, 2024 14:34
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@winder winder requested a review from asoliman92 October 7, 2024 15:07
@winder winder changed the title Add router to DestReaderConfig. Add router to Source/Dest ReaderConfig. Oct 7, 2024
@winder winder added this pull request to the merge queue Oct 7, 2024
Merged via the queue into develop with commit dacb6a8 Oct 7, 2024
149 checks passed
@winder winder deleted the will/router-config branch October 7, 2024 16:11
This was referenced Oct 7, 2024
Draft
Draft
Draft
This was referenced Oct 21, 2024
Draft
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateusz-sekara mateusz-sekara mateusz-sekara approved these changes

@makramkd makramkd makramkd approved these changes

@asoliman92 asoliman92 asoliman92 approved these changes

@jmank88 jmank88 jmank88 approved these changes

@rstout rstout Awaiting requested review from rstout rstout is a code owner automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xnogo 0xnogo Awaiting requested review from 0xnogo 0xnogo is a code owner automatically assigned from smartcontractkit/ccip-offchain

@reductionista reductionista Awaiting requested review from reductionista reductionista is a code owner automatically assigned from smartcontractkit/foundations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@winder @jmank88 @asoliman92 @makramkd @mateusz-sekara