Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(feeds) adds support for non EVM chain configs #14731

Merged
merged 9 commits into from
Oct 14, 2024
Merged

feat(feeds) adds support for non EVM chain configs #14731

merged 9 commits into from
Oct 14, 2024

Conversation

giogam
Copy link
Collaborator

@giogam giogam commented Oct 11, 2024 •
edited
Loading

@giogam giogam requested review from eutopian, yevshev and a team as code owners October 11, 2024 10:35
@github-actions GitHub Actions
Copy link
Contributor

WF: CI Core#75cc6ed

No errors found in this run. 🎉

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024 •
edited
Loading

WF: CI Core#ef641b8

No errors found in this run. 🎉

@giogam giogam requested a review from a team as a code owner October 11, 2024 13:27
@giogam giogam requested a review from Atrax1 October 11, 2024 13:27
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024 •
edited
Loading

WF: CI Core#5baa1eb

No errors found in this run. 🎉

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024 •
edited
Loading

Below is an analysis created by an LLM. Be mindful of hallucinations and verify accuracy.

WF: CI Core#d0331d0

Error: Git Repository Dirty After Operations

Source of Error: 
Clean Go Tidy & Generate	Ensure clean after generate	2024-10-11T16:22:48.2701549Z ##[error]Process completed with exit code 1.
Clean Go Tidy & Generate	Ensure clean after generate	2024-10-11T16:22:48.1548876Z core/services/feeds/mocks/connections_manager.go | 18 ++--
Clean Go Tidy & Generate	Ensure clean after generate	2024-10-11T16:22:48.1550010Z core/services/feeds/mocks/feeds_manager_client.go | 112 +++++++++++-----------

Why:
The error indicates that the Git repository was left in a dirty state after some operations, likely go generate or similar commands that modify the code or generate new code. This is confirmed by the git diff --stat --exit-code command, which exits with code 1 if there are changes.

Suggested Fix:
Ensure that all code generation and modifications during the build process are either committed before this check or reverted. If the changes are intentional and should be part of the repository, they should be committed in a separate step before running this check. Alternatively, adjust the CI pipeline to ignore these files or directories in the git diff command if they are meant to be changed frequently.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024 •
edited
Loading

WF: CI Core#73a08e7

No errors found in this run. 🎉

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024 •
edited
Loading

WF: CI Core#2fee8c0

No errors found in this run. 🎉

@jkongie jkongie enabled auto-merge October 11, 2024 17:59
@jkongie jkongie added this pull request to the merge queue Oct 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 11, 2024
graham-chainlink
graham-chainlink reviewed Oct 14, 2024
View reviewed changes
core/services/feeds/models.go
case "SOLANA":
return ChainTypeSolana, nil
case "APTOS":
return ChainTypeAptos, nil
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are missing cosmos as well, but we can get this PR in first (not that we need it for aptos)

@graham-chainlink graham-chainlink mentioned this pull request Oct 14, 2024
Closed
@archseer archseer enabled auto-merge October 14, 2024 07:32
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 14, 2024 •
edited
Loading

WF: CI Core#f430c5b

No errors found in this run. 🎉

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@archseer archseer added this pull request to the merge queue Oct 14, 2024
Merged via the queue into develop with commit 44daea3 Oct 14, 2024
128 of 129 checks passed
@archseer archseer deleted the DPA-1153/core-node-aptos-ensure-aptos-chain-type-can-be-synced-to-jd branch October 14, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graham-chainlink graham-chainlink graham-chainlink left review comments

@ChrisAmora ChrisAmora ChrisAmora approved these changes

@eutopian eutopian eutopian approved these changes

@jkongie jkongie jkongie approved these changes

@yevshev yevshev Awaiting requested review from yevshev

@Atrax1 Atrax1 Awaiting requested review from Atrax1 Atrax1 is a code owner automatically assigned from smartcontractkit/foundations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@giogam @jkongie @eutopian @ChrisAmora @graham-chainlink @archseer