Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use csa key as default encryption key when registering nodes in cap reg #14758

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

krehermann
Copy link
Contributor

@krehermann krehermann commented Oct 14, 2024

KS-472

Use CSA public key as the default EncryptionPublicKey when registering nodes in the capability registry

@krehermann krehermann requested a review from a team as a code owner October 14, 2024 14:27
@cl-sonarqube-production
Copy link

Copy link
Contributor

WF: CI Core#dbfc2c8

No errors found in this run. 🎉

Signer [32]byte // note that in capabilities registry we need a [32]byte, but in the forwarder we need a common.Address [20]byte
P2PKey p2pkey.PeerID
EncryptionPublicKey [32]byte
IsBoostrap bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: IsBootstrap

@krehermann krehermann added this pull request to the merge queue Oct 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2024
@krehermann krehermann added this pull request to the merge queue Oct 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2024
@krehermann krehermann enabled auto-merge October 14, 2024 19:36
@krehermann krehermann added this pull request to the merge queue Oct 14, 2024
Merged via the queue into develop with commit 2a47a4d Oct 14, 2024
130 checks passed
@krehermann krehermann deleted the ks-472/default-enc-key branch October 14, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants