Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCIP-3785 fix data availability bytes length calc #14798

Merged
merged 15 commits into from
Oct 17, 2024
Merged

CCIP-3785 fix data availability bytes length calc #14798

merged 15 commits into from
Oct 17, 2024

Conversation

0xsuryansh
Copy link
Member

@0xsuryansh 0xsuryansh commented Oct 16, 2024 •
edited
Loading

PR fixing comments and fixed bytes overhead calculation in Internal.sol

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 16, 2024 •
edited
Loading

Below is an analysis created by an LLM. Be mindful of hallucinations and verify accuracy.

WF: CI Core#d2be3c1

1. External service unavailable during push request:[Flakey Test Detection]

Source of Error: 
Flakey Test Detection	Re-run tests	2024-10-16T10:54:27.3999489Z 2024/10/16 10:54:27 Error re-running flakey tests: push request failed: status=503, body=<html>
Flakey Test Detection	Re-run tests	2024-10-16T10:54:27.4001862Z <head><title>503 Service Temporarily Unavailable</title></head>
Flakey Test Detection	Re-run tests	2024-10-16T10:54:27.4003126Z <body>
Flakey Test Detection	Re-run tests	2024-10-16T10:54:27.4004206Z <center><h1>503 Service Temporarily Unavailable</h1></center>
Flakey Test Detection	Re-run tests	2024-10-16T10:54:27.4008099Z <hr><center>nginx</center>
Flakey Test Detection	Re-run tests	2024-10-16T10:54:27.4013456Z </body>
Flakey Test Detection	Re-run tests	2024-10-16T10:54:27.4013884Z </html>
Flakey Test Detection	Re-run tests	2024-10-16T10:54:27.4024704Z ##[error]Process completed with exit code 1.

Why: The error occurred because the external service required to complete the push request was temporarily unavailable, as indicated by the HTTP 503 status code.

Suggested fix: Implement retry logic with exponential backoff in the push request handling to manage temporary unavailability of external services.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 16, 2024 •
edited
Loading

Below is an analysis created by an LLM. Be mindful of hallucinations and verify accuracy.

WF: CI Core#41a8e12

Uncommitted changes detected in repository:Clean Go Tidy & Generate

Source of Error: 
Clean Go Tidy & Generate	Ensure clean after generate	2024-10-16T11:09:16.7580298Z core/gethwrappers/ccip/generated/fee_quoter/fee_quoter.go | 2 +-
Clean Go Tidy & Generate	Ensure clean after generate	2024-10-16T11:09:16.7581990Z .../generation/generated-wrapper-dependency-versions-do-not-edit.txt | 2 +-
Clean Go Tidy & Generate	Ensure clean after generate	2024-10-16T11:09:16.9500037Z ##[error]Process completed with exit code 1.

Why: The error occurred because there were uncommitted changes in the repository after running code generation scripts, which is not allowed in this job's configuration.

Suggested fix: Ensure that the code generation scripts do not modify the repository or add a step to commit changes before this check.

External service temporarily unavailable:Flakey Test Detection

Source of Error: 
Flakey Test Detection	Re-run tests	2024-10-16T11:16:13.2088610Z 2024/10/16 11:16:13 Error re-running flakey tests: push request failed: status=503, body=<html>
Flakey Test Detection	Re-run tests	2024-10-16T11:16:13.2090468Z <head><title>503 Service Temporarily Unavailable</title></head>
Flakey Test Detection	Re-run tests	2024-10-16T11:16:13.2091409Z <body>
Flakey Test Detection	Re-run tests	2024-10-16T11:16:13.2092259Z <center><h1>503 Service Temporarily Unavailable</h1></center>
Flakey Test Detection	Re-run tests	2024-10-16T11:16:13.2093114Z <hr><center>nginx</center>
Flakey Test Detection	Re-run tests	2024-10-16T11:16:13.2093599Z </body>
Flakey Test Detection	Re-run tests	2024-10-16T11:16:13.2094214Z </html>
Flakey Test Detection	Re-run tests	2024-10-16T11:16:13.2112779Z ##[error]Process completed with exit code 1.

Why: The error was caused by a temporary unavailability of an external service (503 Service Temporarily Unavailable), likely used for pushing test results or similar data.

Suggested fix: Implement retry logic with exponential backoff for handling temporary network or service unavailability errors.

@0xsuryansh 0xsuryansh changed the title CCIP-3785 fix availability length bytes CCIP-3785 fix data availability bytes length calc Oct 16, 2024
@0xsuryansh 0xsuryansh marked this pull request as ready for review October 16, 2024 11:52
@0xsuryansh 0xsuryansh requested a review from RayXpub October 16, 2024 14:41
RensR
RensR previously approved these changes Oct 17, 2024
View reviewed changes
@0xsuryansh
Merge branch 'develop' into ccip/fix/fix_dataAvailabilityLengthBytes
acc78cc 
# Conflicts:
#	contracts/gas-snapshots/ccip.gas-snapshot
#	core/gethwrappers/ccip/generated/fee_quoter/fee_quoter.go
#	core/gethwrappers/ccip/generation/generated-wrapper-dependency-versions-do-not-edit.txt
@0xsuryansh
merge fix
eb2e3c2
@github-actions GitHub Actions
Copy link
Contributor

Solidity Review Jira issue

Hey! We have taken the liberty to link this PR to a Jira issue for Solidity Review.

This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one.
Please reach out to the Test Tooling team and notify them about any issues you encounter.

Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: contracts/.changeset/chatty-keys-kneel.md

This PR has been linked to Solidity Review Jira issue:

@0xsuryansh 0xsuryansh requested a review from a team as a code owner October 17, 2024 14:25
@0xsuryansh 0xsuryansh requested a review from RensR October 17, 2024 14:42
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 17, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@0xsuryansh 0xsuryansh enabled auto-merge October 17, 2024 15:09
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@0xsuryansh 0xsuryansh added this pull request to the merge queue Oct 17, 2024
Merged via the queue into develop with commit 26e22eb Oct 17, 2024
167 checks passed
@0xsuryansh 0xsuryansh deleted the ccip/fix/fix_dataAvailabilityLengthBytes branch October 17, 2024 18:25
This was referenced Oct 17, 2024
Draft
Draft
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RayXpub RayXpub RayXpub approved these changes

@vyzaldysanchez vyzaldysanchez vyzaldysanchez approved these changes

@RensR RensR RensR approved these changes

@matYang matYang Awaiting requested review from matYang

@jhweintraub jhweintraub Awaiting requested review from jhweintraub

@RyanRHall RyanRHall Awaiting requested review from RyanRHall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xsuryansh @RensR @vyzaldysanchez @RayXpub