Chain fee integration tests #14829

asoliman92 · 2024-10-17T14:41:43Z

Add FeeQuoter to SourceChain config
Add assertions to make sure that in the initial_deploy_test we update the gas fees
Clean up token assertions in initial_deploy_test

corresponding change on chainlink-ccip:

Fix: OnRamp discovery chainlink-ccip#249

github-actions · 2024-10-18T15:45:21Z

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

core/capabilities/ccip/configs/evm/contract_reader.go

integration-tests/deployment/ccip/changeset/initial_deploy_test.go

Add missing function from DestConfig Debugging Fix OnRamp.GetDestChainConfig All destChain configs have same Router address which is the same as the chainSel. We just need to call with a different destChainSelector Cleaning Clean contract configs Clean contract configs Add Gas Price test in initial_deploy_test.go Bump chainlink-ccip Bump chainlink-ccip cleaning cmoments linting skip failing test for now unskip

AnieeG

For future please create tickets for each TODO

integration-tests/deployment/ccip/changeset/initial_deploy_test.go

cl-sonarqube-production · 2024-10-22T17:24:42Z

Quality Gate passed

Issues
0 New issues
5 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.6% Duplication on New Code

See analysis details on SonarQube

makramkd · 2024-10-22T17:42:57Z

integration-tests/deployment/ccip/token_info.go

@@ -32,6 +33,7 @@ func (tc *TokenConfig) UpsertTokenInfo(
 func (tc *TokenConfig) GetTokenInfo(
 	lggr logger.Logger,
 	linkToken *burn_mint_erc677.BurnMintERC677,
+	wethToken *weth9.WETH9,


I'm not super familiar with this code but is this TokenConfig struct really needed? We should use the existing offchain config types directly where possible to reduce this churn of code that wraps other stuff IMO. The more "glue code" there is for the tests the less likely it is devs would be effectively working on them. That's an issue with the integration-tests code today as well

It is used to initiate offchain config. Just getting the correct addresses and returning them in a correct format.

makramkd · 2024-10-22T17:44:15Z

integration-tests/deployment/ccip/test_helpers.go

+	deployFunc func(deployment.Chain) ContractDeploy[*aggregator_v3_interface.AggregatorV3Interface],
+	symbol TokenSymbol,
+) (common.Address, string, error) {
+	//tokenTV := deployment.NewTypeAndVersion(PriceFeed, deployment.Version1_0_0)


Delete commented line

timweri

go.mod and go.sum files ✅

* Add FeeQuoter to SourceConfig Add missing function from DestConfig Debugging Fix OnRamp.GetDestChainConfig All destChain configs have same Router address which is the same as the chainSel. We just need to call with a different destChainSelector Cleaning Clean contract configs Clean contract configs Add Gas Price test in initial_deploy_test.go Bump chainlink-ccip Bump chainlink-ccip cleaning cmoments linting skip failing test for now unskip * Bump chainlink-ccip * Remove deprecated thing. * Remove replacement. * gomodtidy * skip TestAddChainInbound * Add weth feed * Comment assertions to use better ones in a subsequent PR * Address review comments * cleaning * linting --------- Co-authored-by: Will Winder <[email protected]>

* develop: rm gethwrappers from codeowners offchain (#14919) CCIP-3899 fix sender encoding (#14877) ccip: use unknown address type. (#14836) [chore] Add changeset entry for RequestRoundTracker fix (#14912) various Solidity Foundry updates (#14866) CCIP-3710 create new custom calldata L1 (DA) gas oracle (#14710) CCIP owns smoke test (#14906) core/services/ocr2/plugins/ccip/internal/ccipdata/factory: check error from TypeAndVersion (#14861) CCIP-3730 Misc ccip onchain changes (#14845) Chain fee integration tests (#14829) release/2.17.0 -> develop (#14721) Solana: re-enable disabled test with updated version (#14892)

* Add FeeQuoter to SourceConfig Add missing function from DestConfig Debugging Fix OnRamp.GetDestChainConfig All destChain configs have same Router address which is the same as the chainSel. We just need to call with a different destChainSelector Cleaning Clean contract configs Clean contract configs Add Gas Price test in initial_deploy_test.go Bump chainlink-ccip Bump chainlink-ccip cleaning cmoments linting skip failing test for now unskip * Bump chainlink-ccip * Remove deprecated thing. * Remove replacement. * gomodtidy * skip TestAddChainInbound * Add weth feed * Comment assertions to use better ones in a subsequent PR * Address review comments * cleaning * linting --------- Co-authored-by: Will Winder <[email protected]>

asoliman92 marked this pull request as ready for review October 21, 2024 10:36

asoliman92 requested review from a team as code owners October 21, 2024 10:36

asoliman92 requested review from winder, rstout, makramkd, dimkouv, mateusz-sekara and 0xnogo October 21, 2024 10:36

mateusz-sekara previously approved these changes Oct 21, 2024

View reviewed changes

winder reviewed Oct 21, 2024

View reviewed changes

core/capabilities/ccip/configs/evm/contract_reader.go Show resolved Hide resolved

winder previously approved these changes Oct 21, 2024

View reviewed changes

asoliman92 enabled auto-merge October 21, 2024 13:33

winder reviewed Oct 21, 2024

View reviewed changes

core/capabilities/ccip/configs/evm/contract_reader.go Outdated Show resolved Hide resolved

asoliman92 dismissed stale reviews from winder and mateusz-sekara via 1adc8c0 October 21, 2024 13:39

makramkd previously approved these changes Oct 21, 2024

View reviewed changes

asoliman92 dismissed makramkd’s stale review via 98e5ac2 October 21, 2024 14:30

asoliman92 requested review from a team as code owners October 21, 2024 14:30

asoliman92 requested a review from jmank88 October 21, 2024 14:30

asoliman92 changed the title ~~Add FeeQuoter to SourceConfig~~ Chain fee integration tests Oct 21, 2024

connorwstein reviewed Oct 21, 2024

View reviewed changes

integration-tests/deployment/ccip/changeset/initial_deploy_test.go Outdated Show resolved Hide resolved

integration-tests/deployment/ccip/changeset/initial_deploy_test.go Outdated Show resolved Hide resolved

asoliman92 force-pushed the fix-fee-quoter branch from 395e8d6 to d2e5ac0 Compare October 22, 2024 07:21

winder force-pushed the fix-fee-quoter branch from 3bb786a to ea86129 Compare October 22, 2024 13:24

Bump chainlink-ccip

c6230b4

Remove deprecated thing.

f95de90

winder mentioned this pull request Oct 22, 2024

Fix: OnRamp discovery smartcontractkit/chainlink-ccip#249

Merged

winder added 2 commits October 22, 2024 09:48

Remove replacement.

0120ff5

gomodtidy

d84c55a

winder mentioned this pull request Oct 22, 2024

Fix AddChainInbound smartcontractkit/chainlink-ccip#254

Merged

asoliman92 added 6 commits October 22, 2024 20:34

skip TestAddChainInbound

13943b9

Add weth feed

d328f55

Comment assertions to use better ones in a subsequent PR

faee24d

Address review comments

6977283

cleaning

aec7d49

linting

add92a6

AnieeG approved these changes Oct 22, 2024

View reviewed changes

integration-tests/deployment/ccip/changeset/initial_deploy_test.go Outdated Show resolved Hide resolved

makramkd reviewed Oct 22, 2024

View reviewed changes

winder approved these changes Oct 22, 2024

View reviewed changes

chainchad approved these changes Oct 22, 2024

View reviewed changes

timweri approved these changes Oct 22, 2024

View reviewed changes

asoliman92 added this pull request to the merge queue Oct 22, 2024

Merged via the queue into develop with commit 83c3a32 Oct 22, 2024
147 checks passed

asoliman92 deleted the fix-fee-quoter branch October 22, 2024 18:17

github-actions bot mentioned this pull request Oct 22, 2024

[DO NOT MERGE] Changeset Release Preview - v2.20.0 #13148

Draft

github-actions bot mentioned this pull request Oct 23, 2024

[DO NOT MERGE] Changeset Release Preview - v2.18.0 picoinnetwork/chainlink#1

Draft

github-actions bot mentioned this pull request Oct 24, 2024

[DO NOT MERGE] Changeset Release Preview - v2.18.0 fanligroup/chainlink#1

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chain fee integration tests #14829

Chain fee integration tests #14829

asoliman92 commented Oct 17, 2024 •

edited by winder

Loading

github-actions bot commented Oct 18, 2024 •

edited

Loading

AnieeG left a comment

cl-sonarqube-production bot commented Oct 22, 2024

makramkd Oct 22, 2024

asoliman92 Oct 22, 2024

makramkd Oct 22, 2024

timweri left a comment

Chain fee integration tests #14829

Chain fee integration tests #14829

Conversation

asoliman92 commented Oct 17, 2024 • edited by winder Loading

github-actions bot commented Oct 18, 2024 • edited Loading

AER Report: CI Core ran successfully ✅

AER Report: Operator UI CI ran successfully ✅

AnieeG left a comment

Choose a reason for hiding this comment

cl-sonarqube-production bot commented Oct 22, 2024

Quality Gate passed

makramkd Oct 22, 2024

Choose a reason for hiding this comment

asoliman92 Oct 22, 2024

Choose a reason for hiding this comment

makramkd Oct 22, 2024

Choose a reason for hiding this comment

timweri left a comment

Choose a reason for hiding this comment

asoliman92 commented Oct 17, 2024 •

edited by winder

Loading

github-actions bot commented Oct 18, 2024 •

edited

Loading