Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FHE empty slice fix #14857

Merged
merged 4 commits into from
Oct 22, 2024
Merged

FHE empty slice fix #14857

merged 4 commits into from
Oct 22, 2024

Conversation

dimriou
Copy link
Collaborator

@dimriou dimriou commented Oct 21, 2024

On some chains, eth_feeHistory call returns empty slices instead of 0x0 values when rewards are absent, unlike the standard Geth API. Update FHE to handle this case and not throw an error.
BCFR-1063

@dimriou dimriou requested review from a team as code owners October 21, 2024 09:43
@dimriou dimriou requested a review from ilija42 October 21, 2024 09:43
@dimriou dimriou added this pull request to the merge queue Oct 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 22, 2024
@dimriou dimriou added this pull request to the merge queue Oct 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 22, 2024
Copy link
Contributor

github-actions bot commented Oct 22, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@ilija42 ilija42 enabled auto-merge October 22, 2024 11:22
@ilija42 ilija42 added this pull request to the merge queue Oct 22, 2024
Merged via the queue into develop with commit b8ae4ad Oct 22, 2024
128 checks passed
@ilija42 ilija42 deleted the bcfr-1063_fhe_empty_slice_fix branch October 22, 2024 11:43
0xsuryansh pushed a commit that referenced this pull request Oct 23, 2024
* FHE empty slice fix

* Add changeset
cedric-cordenier pushed a commit that referenced this pull request Oct 24, 2024
* FHE empty slice fix

* Add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants