Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add authenticated ping endpoint #1491

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Conversation

dimroc
Copy link
Contributor

@dimroc dimroc commented Jul 29, 2019

https://www.pivotaltracker.com/story/show/167377145

GET /v2/ping with either cookie or external initiator credentials.

@dimroc dimroc force-pushed the features/external-initiator-ping branch from 74eab10 to 8187fab Compare July 29, 2019 21:32
@dimroc dimroc marked this pull request as ready for review July 29, 2019 21:33
@dimroc dimroc requested review from se3000 and jleeh July 29, 2019 22:47
Copy link
Contributor

@jleeh jleeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't be using this solely to check the health of a node as it's authenticated & requires db lock, but in the context of the deviator this works for me.

@dimroc
Copy link
Contributor Author

dimroc commented Jul 31, 2019

To add more context, this serves as the backend ping endpoint for deviator's /health endpoint. It uses its external initiator credentials to authenticate: https://github.com/smartcontractkit/deviator/pull/14

@dimroc dimroc merged commit d98353c into develop Jul 31, 2019
@dimroc dimroc deleted the features/external-initiator-ping branch July 31, 2019 12:13
RyanRHall added a commit that referenced this pull request Oct 11, 2024
On some chains, it is possible the gas price will just always be zero or
will be fixed at some constant fee

Make stalenessThreshold per dest chain and have 0 mean no staleness
check
RyanRHall added a commit that referenced this pull request Oct 11, 2024
On some chains, it is possible the gas price will just always be zero or
will be fixed at some constant fee

Make stalenessThreshold per dest chain and have 0 mean no staleness
check
RyanRHall added a commit that referenced this pull request Oct 15, 2024
On some chains, it is possible the gas price will just always be zero or
will be fixed at some constant fee

Make stalenessThreshold per dest chain and have 0 mean no staleness
check
RyanRHall added a commit that referenced this pull request Oct 15, 2024
On some chains, it is possible the gas price will just always be zero or
will be fixed at some constant fee

Make stalenessThreshold per dest chain and have 0 mean no staleness
check
RyanRHall added a commit that referenced this pull request Oct 15, 2024
On some chains, it is possible the gas price will just always be zero or
will be fixed at some constant fee

Make stalenessThreshold per dest chain and have 0 mean no staleness
check
github-merge-queue bot pushed a commit that referenced this pull request Oct 16, 2024
…1491) (#14734)

* Make gas fee staleness threshold configurable per chain (#1491)

On some chains, it is possible the gas price will just always be zero or
will be fixed at some constant fee

Make stalenessThreshold per dest chain and have 0 mean no staleness
check

* add changeset

* fix offchain code

* update structs in integration-tests

* update core changeset

* [Bot] Update changeset file with jira issues

* update snapshot & wrapper

---------

Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com>
mateusz-sekara pushed a commit that referenced this pull request Jan 10, 2025
## Motivation
On some chains, it is possible the gas price will just always be zero or
will be fixed at some constant fee

## Solution
Make stalenessThreshold per dest chain and have 0 mean no staleness
check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants