Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCFR-144 enforce repeatable read #14978

Merged

Conversation

dhaidashenko
Copy link
Collaborator

@dhaidashenko dhaidashenko commented Oct 28, 2024

EnforceRepeatableRead = true guarantees that MultiNode will not route requests to an RPC that laggs on the latest finalized block.

FinalizedBlockOffset was increased on chains with mean finalized block time <= 30s to gracefully handle cases when RPCs constantly lag behind on the latest finalized block.
Screenshot 2024-10-28 at 11 46 16

Copy link
Contributor

github-actions bot commented Oct 28, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@dhaidashenko dhaidashenko marked this pull request as ready for review October 29, 2024 12:16
@dhaidashenko dhaidashenko requested review from a team as code owners October 29, 2024 12:16
Copy link
Contributor

@prashantkumar1982 prashantkumar1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asked a separate question about whether we have enough metrics to alarm us when all RPCs go out of sync due to lagging on Finality.
But this change overall is good.

@prashantkumar1982
Copy link
Contributor

Asked a separate question about whether we have enough metrics to alarm us when all RPCs go out of sync due to lagging on Finality. But this change overall is good.

From @dhaidashenko : If on new request there is no healthy RPC we'll log a critical error. It does not contain actual reason, but it could be used as a signal for deeper investigation.
We also periodically report all RPCs states (both via logging and prometheus), where we'll explicitly see if RPC is in FinalizedBlockOutOfSync state.

@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Oct 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 31, 2024
@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Oct 31, 2024
Merged via the queue into develop with commit 65351c3 Nov 1, 2024
132 checks passed
@prashantkumar1982 prashantkumar1982 deleted the feature/BCFR-144-multinode-enforce-repeatable-read branch November 1, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants