-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BCFR-144 enforce repeatable read #14978
BCFR-144 enforce repeatable read #14978
Conversation
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asked a separate question about whether we have enough metrics to alarm us when all RPCs go out of sync due to lagging on Finality.
But this change overall is good.
From @dhaidashenko : If on new request there is no healthy RPC we'll log a critical error. It does not contain actual reason, but it could be used as a signal for deeper investigation. |
EnforceRepeatableRead = true
guarantees that MultiNode will not route requests to an RPC that laggs on the latest finalized block.FinalizedBlockOffset
was increased on chains with mean finalized block time<= 30s
to gracefully handle cases when RPCs constantly lag behind on the latest finalized block.