-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nonevm 825/remove evm config dependency from plugin #15126
Nonevm 825/remove evm config dependency from plugin #15126
Conversation
Flaky Test Detector for
|
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
Flaky Test Detector for
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://smartcontract-it.atlassian.net/browse/NONEVM-825
Make oracle creater chain agnostic by removing dependency of evmConfig.
When relayer creates the chainWriter here, we can pass the existing maxGasPrice from relayer (r.chain.Config().EVM().GasEstimator().PriceMax()), instead of having the chain writer config keeping the maxGasPrice. That way we can remove the dependency of evmConfig