Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonevm 825/remove evm config dependency from plugin #15126

Merged

Conversation

huangzhen1997
Copy link
Contributor

@huangzhen1997 huangzhen1997 commented Nov 5, 2024

https://smartcontract-it.atlassian.net/browse/NONEVM-825

Make oracle creater chain agnostic by removing dependency of evmConfig.

When relayer creates the chainWriter here, we can pass the existing maxGasPrice from relayer (r.chain.Config().EVM().GasEstimator().PriceMax()), instead of having the chain writer config keeping the maxGasPrice. That way we can remove the dependency of evmConfig

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Flaky Test Detector for ./go.mod project has failed ❌

Ran new or updated tests between develop and 0372c3b (NONEVM-825/remove-evmConfig-dependency-from-plugin).

View Flaky Detector Details | Compare Changes

Failed Tests

Ran 9 tests in total for all affected test packages. Below are the tests identified as flaky, with a pass ratio lower than the 100% threshold:

TestPackage                                                                  TestName                                       PassRatio  RunCount   Skipped
---------                                                                    ---------                                      ---------  ---------  ---------
github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/configs/evm  TestChainWriterConfigRaw                       0%         1          false
github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/configs/evm  TestChainWriterConfigRaw/valid_input           0%         1          false
github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/configs/evm  TestChainWriterConfigRaw/nil_maxGasPrice       0%         1          false
github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/configs/evm  TestChainWriterConfigRaw/zero_maxGasPrice      0%         1          false
github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/configs/evm  TestChainWriterConfigRaw/negative_maxGasPrice  0%         1          false

Copy link
Contributor

github-actions bot commented Nov 5, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Flaky Test Detector for ./go.mod project has failed ❌

Ran new or updated tests between develop and 040245c (NONEVM-825/remove-evmConfig-dependency-from-plugin).

View Flaky Detector Details | Compare Changes

Failed Tests

Ran 9 tests in total for all affected test packages. Below are the tests identified as flaky, with a pass ratio lower than the 100% threshold:

TestPackage                                                                  TestName                                       PassRatio  RunCount   Skipped
---------                                                                    ---------                                      ---------  ---------  ---------
github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/configs/evm  TestChainWriterConfigRaw/zero_maxGasPrice      0%         1          false
github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/configs/evm  TestChainWriterConfigRaw/negative_maxGasPrice  0%         1          false
github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/configs/evm  TestChainWriterConfigRaw                       0%         1          false
github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/configs/evm  TestChainWriterConfigRaw/valid_input           0%         1          false
github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/configs/evm  TestChainWriterConfigRaw/nil_maxGasPrice       0%         1          false

@huangzhen1997 huangzhen1997 marked this pull request as ready for review November 5, 2024 20:36
@huangzhen1997 huangzhen1997 requested review from a team as code owners November 5, 2024 20:36
Copy link
Contributor

@silaslenihan silaslenihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrick-dowell patrick-dowell added this pull request to the merge queue Nov 6, 2024
Merged via the queue into develop with commit bf9b08c Nov 6, 2024
157 of 158 checks passed
@patrick-dowell patrick-dowell deleted the NONEVM-825/remove-evmConfig-dependency-from-plugin branch November 6, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants