Adding InstanceAppFactoryWithKeystoreMock for shell_local tests #15167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cll-gg
reviewed
Nov 8, 2024
| if err != nil { | ||
| return nil, fmt.Errorf("error authenticating keystore: %w", err) | ||
| } | ||
| return f.App, nil |
There was a problem hiding this comment.
Should we also add err = keyStore.CSA().EnsureKey(ctx)?
(See https://github.com/smartcontractkit/chainlink/pull/15040/files#diff-1d22c137e223ec960bb1341e18d1a7ca6858111c67cfc3ee09f1b4da18904c96R205)
There was a problem hiding this comment.
We do want to ensure the csa key for beholder, but testing the unlock via password mechanism of the keystore seems a separate concern to me
cll-gg
approved these changes
Nov 8, 2024
patrickhuie19
requested review from
pavel-raykov
and removed request for
a team
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 8, 2024
* Bump chainlink-common to PR latest * Wire up Beholder auth in loop * Move keystore auth into NewApplication * Wire up CSA Auth for Beholder * Use simplified auth header approach * Add auth header after logging config * Remove empty line for linter * Put back mistakenly removed imports * Update to latest chainlink-common@INFOPLAT-1071-beholder-csa-signer-auth_2 * Rename return vars Co-authored-by: Jordan Krage <[email protected]> * Bump chainlink-common from latest INFOPLAT-1071-beholder-csa-signer-auth_2 * Bump chainlink-common to latest INFOPLAT-1071-beholder-csa-signer-auth_2 * Bump chainlink-common to latest INFOPLAT-1071-beholder-csa-signer-auth_2 * go mod tidy for ./integration-tests * make gomodtidy * Add changeset file * Potential test fix * Clean up the test: remove a few unused mocks * Revert "Clean up the test: remove a few unused mocks" This reverts commit f55cc8e. * Revert "Potential test fix" This reverts commit cb348aa. * Adding InstanceAppFactoryWithKeystoreMock for shell_local tests (#15167) * Revert "remove go.mod replace with real version (#15142)" This reverts commit d61ce51. * Run go mod tidy * Add Beholder auth to deployment LoopRegistry * Update chainlink-common to PR latest * Run go mod tidy * Prep keystore for beholder auth * Bump chainlink-common to latest * Run go mod tidy --------- Co-authored-by: 4of9 <[email protected]> Co-authored-by: Geert G <[email protected]> Co-authored-by: Jordan Krage <[email protected]> Co-authored-by: patrickhuie19 <[email protected]> Co-authored-by: krehermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Supports