Improve peer group dialer sync function logs #15867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimkouv
requested review from
winder,
asoliman92,
makramkd,
mateusz-sekara,
0xAustinWang,
0xnogo and
b-gopalswami
dimkouv
commented
Jan 8, 2025
| return | ||
| } | ||
|
|
||
| d.lggr.Infow("Syncing peer groups", "actions", actions) |
There was a problem hiding this comment.
lggr.Levelw uses json for the provided arguments, the actions here are not exported so they cannot be seen in the logs. Switching to Infof.
|
I see you updated files related to
|
dimkouv
commented
Jan 8, 2025
| @@ -373,13 +374,22 @@ func (d *peerGroupDialer) sync() { | |||
| defer d.mu.Unlock() | |||
|
|
|||
| activeDigest, candidateDigest := d.rmnHomeReader.GetAllConfigDigests() | |||
|
|
|||
| lggr := logger2.With( | |||
There was a problem hiding this comment.
Included all the config digests to be able to debug the computed actions.
|
asoliman92
approved these changes
Jan 9, 2025
mateusz-sekara
approved these changes
Jan 9, 2025
asoliman92
pushed a commit
that referenced
this pull request
Jan 9, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 9, 2025
…15605) * replace f with fObserve in RMHome and RMNRemote * Update gethwrappers * rename fObserve to fSign * fix off-chain components of renaming RMN parameters * core changeset * update missing file for new parameter name * fix wrappers * fix merge conflict broken text * Update gethwrappers * attempt fix json export tag * Update gethwrappers * upgrade cl-ccip and fix test * upgrade cl-ccip@main * upgrade cl-ccip@main * fix test * upgrade cl-ccip@main * Update gethwrappers * upgrade chainlink ccip * DEVSVCS-1087: remove unused automation hardhat tests (#15847) * remove unused automation hardhat tests * freeze contracts * remove more tests * update * CCIP Config backported from CCIP repo (#15856) * Moving configs directly from CCIP repo * Moving configs directly from CCIP repo * Remove panic recovery for wsrpc (#15865) - Due to some other bug in the library, the redialled connection never becomes ready. * Added is_backfiled filed to solana's filter table (#15796) * Extract MultiNode to chainlink-framework (#15791) * Extract MultiNode * tidy * tidy * Fix generate * Add mock Subscription * lint * Fix sendonly allocation * lint * Add QueryTimeout to client * Use multinode * Update rpc_client_test.go * improve peer group dialer sync function logs (#15867) * Solana devnet spin up in memory env (A) (#15831) * Adding solchains in NewEnv * Revert "Adding solchains in NewEnv" This reverts commit aaab52e. * adding sol chains to newenv * newEnv needs to send nil * adding test env setup * adding nil for crib sol chains * adding chain selectors commit * go mod tidy * linting * chain sel update * update core/scripts go files * again * add changeset * go imports * go mod tidy * Update modgraph --------- Co-authored-by: Terry Tata <[email protected]> Co-authored-by: Blaž Hrastnik <[email protected]> * upgrade chainlink ccip fixing router binding issues in migration * upgrade chainlink ccip fixing router binding issues in migration * fix comment * gomodtidy and formatting fix * update go mod file for newest cl-ccip * update comment --------- Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com> Co-authored-by: Simon B.Robert <[email protected]> Co-authored-by: dimkouv <[email protected]> Co-authored-by: asoliman <[email protected]> Co-authored-by: FelixFan1992 <[email protected]> Co-authored-by: Mateusz Sekara <[email protected]> Co-authored-by: Sam <[email protected]> Co-authored-by: Dmytro Haidashenko <[email protected]> Co-authored-by: Dylan Tinianov <[email protected]> Co-authored-by: Yashvardhan Nevatia <[email protected]> Co-authored-by: Terry Tata <[email protected]> Co-authored-by: Blaž Hrastnik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving the log for debugging purposes