[CCIP-4171] integration-tests/smoke/ccip: add re-org tests

[makramkd]

Requires

Supports

[github-actions]

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , GolangCI Lint (.) , GolangCI Lint (integration-tests) , GolangCI Lint (deployment) , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , test-scripts , Core Tests (go_core_race_tests) , lint , SonarQube Scan

1. Error return value not checked: [Golang Lint (integration-tests)]

Source of Error:

integration-tests/smoke/ccip/ccip_reorg_test.go:195:50: Error return value of `testhelpers.ConfirmCommitWithExpectedSeqNumRange` is not checked (errcheck)
testhelpers.ConfirmCommitWithExpectedSeqNumRange(
 ^

**Why**: The function `testhelpers.ConfirmCommitWithExpectedSeqNumRange` returns an error that is not being checked, which is a common best practice to ensure proper error handling.

Suggested fix: Add error handling for the function call to ensure any potential errors are properly managed.

2. File not goimports-ed: [Golang Lint (integration-tests)]

Source of Error:

integration-tests/smoke/ccip/ccip_reorg_test.go:13: File is not `goimports`-ed with -local github.com/smartcontractkit/chainlink (goimports)
"github.com/smartcontractkit/chainlink-ccip/pkg/types/ccipocr3"

**Why**: The file is not formatted according to the `goimports` tool with the `-local` flag, which helps in organizing imports in a standard way.

Suggested fix: Run goimports -local github.com/smartcontractkit/chainlink -w integration-tests/smoke/ccip/ccip_reorg_test.go to format the file correctly.

3. fmt.Sprintf can be replaced: [Golang Lint (integration-tests)]

Source of Error:

integration-tests/smoke/ccip/ccip_reorg_test.go:109:62: fmt.Sprintf can be replaced with faster strconv.FormatUint (perfsprint)
details, err := chainsel.GetChainDetailsByChainIDAndFamily(fmt.Sprintf("%d", chain.ChainID), chainsel.FamilyEVM)
 ^

**Why**: Using `fmt.Sprintf` for converting integers to strings is less efficient compared to `strconv.FormatUint`.

Suggested fix: Replace fmt.Sprintf("%d", chain.ChainID) with strconv.FormatUint(chain.ChainID, 10) for better performance.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

[cl-sonarqube-production]

Quality Gate passed

Issues
1 New issue
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube