Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Functions] Use latest CBOR & Buffer contracts #8485

Merged
merged 7 commits into from
Mar 15, 2023
Merged

[Functions] Use latest CBOR & Buffer contracts #8485

merged 7 commits into from
Mar 15, 2023

Conversation

justinkaseman
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@github-actions
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make go-solidity-wrappers command

pinebit
pinebit previously approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@pinebit pinebit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as all CI is green, this looks good to me.

@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

justinkaseman
justinkaseman commented Mar 15, 2023
View reviewed changes
contracts/test/v0.8/dev/Functions.test.ts
codeLocation: 0,
source: '',
})
assert.deepEqual(
Copy link
Contributor Author

@justinkaseman justinkaseman Mar 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kludge to avoid adding a new dependency for bignumber.js, which is what the cbor package uses.

@justinkaseman justinkaseman requested review from pinebit and removed request for alexroan March 15, 2023 18:33
@justinkaseman justinkaseman merged commit 30bd147 into develop Mar 15, 2023
@justinkaseman justinkaseman deleted the jk/latest-cbor branch March 15, 2023 18:37
@chainchad chainchad mentioned this pull request Mar 16, 2023
Merged
@chainchad chainchad mentioned this pull request Apr 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KuphJr KuphJr KuphJr approved these changes

@se3000 se3000 Awaiting requested review from se3000

@connorwstein connorwstein Awaiting requested review from connorwstein

@pinebit pinebit Awaiting requested review from pinebit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinkaseman @pinebit @KuphJr