Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/cmd: only run fallback API initializer when file not present #8718

Merged
merged 1 commit into from
Mar 15, 2023
Merged

core/cmd: only run fallback API initializer when file not present #8718

merged 1 commit into from
Mar 15, 2023

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Mar 15, 2023 •
edited
Loading

@github-actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@jmank88 jmank88 requested review from chudilka1 and Bwest981 March 15, 2023 20:33
@jmank88 jmank88 force-pushed the BCF-2139-multi-admin branch from f06ea9c to cc7fba2 Compare March 15, 2023 22:31
@jmank88 jmank88 marked this pull request as ready for review March 15, 2023 22:31
@jmank88 jmank88 requested a review from CL-Andrew March 15, 2023 22:31
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition D Maintainability Rating on New Code (is worse than A)
Failed condition 34.81% Technical Debt Ratio on New Code (is greater than 4%)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint SonarLint in your IDE.

@jmank88 jmank88 merged commit 5622de9 into develop Mar 15, 2023
@jmank88 jmank88 deleted the BCF-2139-multi-admin branch March 15, 2023 22:50
chainchad pushed a commit that referenced this pull request Mar 15, 2023
@jmank88 @chainchad
core/cmd: only run fallback API initializer when file not present (#8718
6bb6534 
)

(cherry picked from commit 5622de9)
chainchad added a commit that referenced this pull request Mar 16, 2023
@chainchad
Merge pull request #8720 from smartcontractkit/chore/bcf-2139-cherry-…
dfbd060 
…pick

core/cmd: only run fallback API initializer when file not present (#8718)
@chainchad chainchad mentioned this pull request Mar 16, 2023
Merged
@chainchad chainchad mentioned this pull request Apr 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsondav samsondav samsondav approved these changes

@chudilka1 chudilka1 Awaiting requested review from chudilka1

@Bwest981 Bwest981 Awaiting requested review from Bwest981

@jkongie jkongie Awaiting requested review from jkongie

@CL-Andrew CL-Andrew Awaiting requested review from CL-Andrew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmank88 @samsondav