BCF-2141: clean up make generate #8722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now `make generate` runs the make commands for `go install`. Previously `make generate` installed some but not all dependencies.
krehermann
requested review from
chainchad,
javuto,
jkongie,
jmank88 and
samsondav
as code owners
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
krehermann
force-pushed
the
bug/codec-make-generate
branch
from
79494a9 to
d7abd0c
Compare
krehermann
force-pushed
the
bug/codec-make-generate
branch
from
d7abd0c to
064e76a
Compare
samsondav
approved these changes
Mar 16, 2023
jmank88
reviewed
Mar 16, 2023
| - name: Ensure clean after generate | ||
| run: git diff --stat --exit-code | ||
| - run: make gomodtidy |
There was a problem hiding this comment.
I think I had tidy first since it is faster? nbd though
There was a problem hiding this comment.
i moved it here since generate is running go install under the hood and i thought might effect the result of gomodtidy
jmank88
approved these changes
Mar 16, 2023
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now
make generateruns the make commands forgo install. Previouslymake generateinstalled some but not all dependencies.