Elwood Optimize /subscriptions call (#3645)

* Reduce the amount of subscription check API calls to when we have valid subscription requests

.changeset/sharp-jobs-draw.md

@@ -0,0 +1,5 @@
+---
+'@chainlink/elwood-adapter': patch
+---
+
+Reduce the frequency of /subscriptions api calls to check active subscriptions to only when we desire to subscribe to a stream.

packages/sources/elwood/src/transport/crypto.ts

@@ -102,6 +102,13 @@ export const transport: WebSocketTransport<WsTransportTypes> =
       // are multiple EAs that share the same key then we should only subscribe to new symbols. For
       // the same reason, it is not safe to unsubscribe otherwise another EA expecting the symbol
       // may unexpectedly stop receiving data for it without knowing.
+
+      // `subscribes` will be populated if there are new subscriptions to be made. This can happen
+      // if we request a new pair to be subscribed to, or if the subscription set TTL has expired
+      if (!subscribes || subscribes.length === 0) return
+
+      logger.info(`Subscription requests: ${JSON.stringify(subscribes)}`)
+
       const subscriptions = await getSubscriptions(
         context.adapterSettings.API_ENDPOINT,
         context.adapterSettings.API_KEY,

packages/sources/elwood/src/transport/lwba.ts

@@ -104,6 +104,13 @@ export const transport: WebSocketTransport<WsTransportTypes> =
       // are multiple EAs that share the same key then we should only subscribe to new symbols. For
       // the same reason, it is not safe to unsubscribe otherwise another EA expecting the symbol
       // may unexpectedly stop receiving data for it without knowing.
+
+      // `subscribes` will be populated if there are new subscriptions to be made. This can happen
+      // if we request a new pair to be subscribed to, or if the subscription set TTL has expired
+      if (!subscribes || subscribes.length === 0) return
+
+      logger.info(`Subscription requests: ${JSON.stringify(subscribes)}`)
+
       const subscriptions = await getSubscriptions(
         context.adapterSettings.API_ENDPOINT,
         context.adapterSettings.API_KEY,

packages/sources/elwood/test/integration/adapter.test.ts

@@ -75,11 +75,12 @@ describe('websocket', () => {
 
     it('should skip subscribing if already subscribed', async () => {
       const symbol = `${dataAlreadySubscribed.base}-${dataAlreadySubscribed.quote}`
-      mockSubscriptionsResponse(apiKey, [symbol])
+      const subscriptionScope = mockSubscriptionsResponse(apiKey, [symbol])
       const scope = mockSubscribeResponse(apiKey, symbol)
       const response = await testAdapter.request(data)
       expect(response.json()).toMatchSnapshot()
       expect(scope.isDone()).toEqual(false)
+      expect(subscriptionScope.isDone()).toEqual(false)
     })
 
     it('should return success (LWBA)', async () => {