-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added gm-token EA #3123
Added gm-token EA #3123
Conversation
🦋 Changeset detectedLatest commit: f00fb44 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks!
Left a couple of minor comments, but all are non-blocking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thanks for adding the sources in the response!
Left a minor change to an error message - other than that looks good to go!
Closes DF-19319
Description
Added new
gm-token
composite EA to get a price of GM tokens. GM tokens (GM market pools) represent a market pool of a particular market for a specified asset pair.A GM pool (GMX Market pool) consists of:
For example, a market could be ETH/USD[WETH-USDC], in this case:
The EA is made generic so that it can fetch the price of every possible GMToken.
In summary this is how gm-token EA works
To test the EA, first run 3 source EAs that the gm-token is using for price data. Provide relevant env variables
TIINGO_ADAPTER_URL
,NCFX_ADAPTER_URL
COINMETRICS_ADAPTER_URL
Provide
ARBITRUM_RPC_URL
.Run the gm-token EA. To get the gmToken price use one of following request data. The list of gmTokens and their prices can be found here.
Quality Assurance
infra-k8s
configuration file.adapter-secrets
configuration file or update the soak testing blacklist.test-payload.json
file with relevant requests.feature/x
,chore/x
,release/x
,hotfix/x
,fix/x
) or is created from Jira.