-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated readmeBlacklist.json #3151
Conversation
🦋 Changeset detectedLatest commit: 6eebb35 The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✔️ Soak test for gramchain succeeded
✔️ Assertions loaded: 1, applied: 1
Output sample
|
✔️ Soak test for cfbenchmarks succeeded
✔️ Assertions loaded: 1, applied: 1
Output sample
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't go over it super carefully but I think it looks fine
I think we typically add every EA changed into the changeset, even if the change is only docs
130eb74
to
ce54afe
Compare
✔️ Soak test for gramchain succeeded
✔️ Assertions loaded: 1, applied: 1
Output sample
|
✔️ Soak test for cfbenchmarks succeeded
✔️ Assertions loaded: 1, applied: 1
Output sample
|
✔️ Soak test for gramchain succeeded
✔️ Assertions loaded: 1, applied: 1
Output sample
|
✔️ Soak test for cfbenchmarks succeeded
✔️ Assertions loaded: 1, applied: 1
Output sample
|
DF-19046
This PR removes several EAs from
readmeBlacklist.json
so that readmes for those EAs will be generated automatically. The only v3 EA that is still in the black list is thecoingecko
. Coingecko uses custom descriptions for input params and changing them will cause type issues with the ea-framework. While is it not removed from the blacklist, the readme is updated to reflect the latest state of EA.Adapters still in the blacklist are either
. composite ones that use custom descriptions regarding underlying EAs that they use
. source adapters that don't have proper testing setup (instead of request-response testing they test
execute
function) and therefore for them it is not possible to generate request/response examples.. use custom description in different parts of the README file that readme generation script can't handle