Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed alongside integration tests #3175

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

karen-stepanyan
Copy link
Contributor

@karen-stepanyan karen-stepanyan commented Feb 5, 2024

The integration test of Alongside EA somehow didn't have a mock for infura-ipfs api. The test was actually calling the real API and getting the data. Presumably the data was always the same therefore the test snapshots were not failing.

However, in a different PR i noticed alongside integration tests failing and after checking it, it seems that the API that was actually running in the test is now throwing 401 errors. This PR adds the missing mocked response.

Copy link

changeset-bot bot commented Feb 5, 2024

⚠️ No Changeset found

Latest commit: 5fe187d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alecgard
Copy link
Contributor

alecgard commented Feb 5, 2024

Nice catch!

@karen-stepanyan karen-stepanyan merged commit 143d923 into main Feb 5, 2024
8 checks passed
@karen-stepanyan karen-stepanyan deleted the fix-alongside-test branch February 5, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants