Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

market-status: Use NCFX as primary for forex and metals markets #3498

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

martin-cll
Copy link
Collaborator

Use NCFX as primary for forex and metals markets only. All other markets, including future ones, will continue to use TradingHours as primary.

@martin-cll martin-cll requested review from dav009, ad0ll and mjk90 October 23, 2024 03:21
Copy link

changeset-bot bot commented Oct 23, 2024

🦋 Changeset detected

Latest commit: ab6bdbc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@chainlink/market-status-adapter Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

@dav009 dav009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ticking but we need to reflect this change in RDD

@martin-cll
Copy link
Collaborator Author

ticking but we need to reflect this change in RDD

cc @dav009 Despite the resemblance, the order of the secondaryApis field in RDD (example) does not determine or correspond to the order of the order of the EAs used by this composite adapter. The RDD fields record the fact that these 2 underlying EAs are used, but not in which order.

@martin-cll martin-cll merged commit fa34fe9 into main Oct 23, 2024
8 checks passed
@martin-cll martin-cll deleted the ml/market-status-ncfx branch October 23, 2024 03:53
@github-actions github-actions bot mentioned this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants