Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/DF-20681 XPD includes in TP #3501

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Conversation

mmcallister-cll
Copy link
Contributor

@mmcallister-cll mmcallister-cll commented Oct 23, 2024

Closes #DF-20681

Description

Add XPD/USD pair to TP includes file because the pair is returned wrong by the DP (similar to all other metals, XAU, XAG, XPT)

Changes

  • Add XPD/USD to TP includes file

Steps to Test

  1. Sanity test request with "base": "XPD", "quote": "USD"

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

@mmcallister-cll mmcallister-cll requested a review from a team October 23, 2024 22:21
Copy link

changeset-bot bot commented Oct 23, 2024

🦋 Changeset detected

Latest commit: 2531cdf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@chainlink/tp-adapter Patch
@chainlink/icap-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

mxiao-cll
mxiao-cll previously approved these changes Oct 23, 2024
@mmcallister-cll mmcallister-cll merged commit 7194e0f into main Oct 24, 2024
8 checks passed
@mmcallister-cll mmcallister-cll deleted the chore/DF-20681-XPD-includes-tp branch October 24, 2024 01:00
@github-actions github-actions bot mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants