Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test scripts on Windows #28

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Conversation

SebasG22
Copy link
Contributor

Description

Changing ; to && fixes the following issue:

$ yarn test
yarn run v1.22.10
warning ..\package.json: No license field
$ hardhat test test/unit/PriceConsumerV3_unit_test.js --network hardhat; hardhat test test/unit/APIConsumer_unit_test.js --network hardhat; hardhat test test/unit/RandomNumberConsumer_unit_test.js --network hardhat
Error HH309: Repeated parameter --network

For more info go to https://hardhat.org/HH309 or run Hardhat with --show-stack-traces
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Screenshots

As you can see executing the command yarn test works on Windows.
image

Changing `;` to `&&` fixes the following issue:
```bash
$ yarn test
yarn run v1.22.10
warning ..\package.json: No license field
$ hardhat test test/unit/PriceConsumerV3_unit_test.js --network hardhat; hardhat test test/unit/APIConsumer_unit_test.js --network hardhat; hardhat test test/unit/RandomNumberConsumer_unit_test.js --network hardhat
Error HH309: Repeated parameter --network

For more info go to https://hardhat.org/HH309 or run Hardhat with --show-stack-traces
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
```
@pappas999
Copy link
Collaborator

thanks for this @SebasG22 , will hopefully help with windows users that have the same issue

@pappas999 pappas999 merged commit ea6770e into smartcontractkit:main Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants