Full APIConsumer unit test mocking MockOracle request fulfillment #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pattern ["ethereumjs-abi@git+https://github.com/ethereumjs/ethereumjs-abi.git"] is trying to unpack in the same destination "/Users/roberto/Library/Caches/Yarn/v6/npm-ethereumjs-abi-0.6.8-integrity/node_modules/ethereumjs-abi" as pattern ["[email protected]","ethereumjs-abi@^0.6.8","[email protected]"]. This could result in non-deterministic behavior, skipping.
|
This looks awesome! @andrejrakic, curious if this is something you can look at? Ideally we'd add the mocking VRF response too. |
|
As part of our Chainlink Hackathon submission, we also developed a task to simulate an oracle in the local test network. This helped during fronted development too. More details: https://github.com/rogargon/YTVideoNFTknz/blob/main/tasks/mockoracle.js |
|
Hey @rogargon thanks for the PR, nice work! One thing, would you be kind to resolve a conflict on your local branch before the review process? Thanks in advance |
# Conflicts: # yarn.lock
|
Thanks! Conflict resolved |
andrejrakic
requested changes
Jan 18, 2022
andrejrakic
approved these changes
Jan 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of the APIConsumer unit test just checks that the request is made. Added a new test that mocks oracle request fulfillment so the full process can be tested. This way, using a local network, it can be tested how the oracle response is processed.