Fixes & chain improvements #98
Conversation
archseer
force-pushed
the
fixes
branch
3 times, most recently
from
96b6fde to
b3f1b8b
Compare
archseer
force-pushed
the
fixes
branch
2 times, most recently
from
45f9131 to
3da7d53
Compare
| import { NonEVMKeysCard } from './NonEVMKeysCard' | ||
| import { useNonEvmAccountsQuery } from 'src/hooks/queries/useNonEvmAccountsQuery' | ||
|
|
||
| const SCHEMAS = { |
There was a problem hiding this comment.
Hmm this seems weird, does graphql not provide the typings?
I guess you have to do the backend change first.
There was a problem hiding this comment.
Can fields also have doc metadata in graphql? If I can get the key name and field names through metadata then that would be great since new tables could be added with core only changes
There was a problem hiding this comment.
Oh cool, looks like I can use annotations: https://stackoverflow.com/questions/39962867/how-do-i-add-a-description-to-a-field-in-graphql-schema-language
There was a problem hiding this comment.
ah i see what you are trying to do, trying to build a dynamic table, okay this make sense!
There was a problem hiding this comment.
Oh cool, looks like I can use annotations: https://stackoverflow.com/questions/39962867/how-do-i-add-a-description-to-a-field-in-graphql-schema-language
hmm never done it before, let me know what you find haha
| }, | ||
| solanaKeys: { | ||
| title: 'Solana', | ||
| fields: [{ label: 'Public Key', key: 'id', copy: true }], |
There was a problem hiding this comment.
since each key always have { label: 'Public Key', key: 'id', copy: true }, i wonder if we always have it in the table instead, so we dont have to specify this for every new chain key?
|
Look good overall from what i can see, however i never really worked on other areas except the chain config page |
|
onchainSigningStrategyto workflows