Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE crash in BaseLifecycleManager on checkLifecycleConfiguration #1783

Closed
kenhuang1120 opened this issue Jan 7, 2022 · 2 comments
Closed

Comments

@kenhuang1120
Copy link

Bug Report

[Summary]
Crash in BaseSdlManager.checkLifecycleConfiguration on line 191. Attempting to call managerListener.managerShouldUpdateLifecycle() when smanagerListener value is null.

Reproduction Steps

Unfortunately unable to reproduce at the moment. This crash came from our Crashlytics logs and has only been observed from version 5.1

OS & Version Information
  • Android Version: Android 7 to 12
  • SDL Android Version: from 5.1
  • Testing Against: No tests as this came from Crashlytics logs.
Test Case, Sample Code, and / or Example App

None currently available. only crash Log

Fatal Exception: java.lang.NullPointerException: Attempt to invoke interface method 'com.smartdevicelink.managers.lifecycle.LifecycleConfigurationUpdate com.smartdevicelink.managers.SdlManagerListener.managerShouldUpdateLifecycle(com.smartdevicelink.proxy.rpc.enums.Language, com.smartdevicelink.proxy.rpc.enums.Language)' on a null object reference
       at com.smartdevicelink.managers.BaseSdlManager.checkLifecycleConfiguration(BaseSdlManager.java:191)
       at com.smartdevicelink.managers.SdlManager$2.run(SdlManager.java:218)
       at android.os.Handler.handleCallback(Handler.java:883)
       at android.os.Handler.dispatchMessage(Handler.java:100)
       at android.os.Looper.loop(Looper.java:359)
       at android.app.ActivityThread.main(ActivityThread.java:7418)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:935)
@kenhuang1120 kenhuang1120 changed the title NPE crash in BaseLifecycleManager when checkLifecycleConfiguration NPE crash in BaseLifecycleManager on checkLifecycleConfiguration Jan 7, 2022
@peterkomar
Copy link

peterkomar commented Jan 20, 2022

I also received similar crash:

Android 11 (SDK 30)

java.lang.NullPointerException: 
  at com.smartdevicelink.managers.BaseSdlManager.checkLifecycleConfiguration (BaseSdlManager.java:191)
  at com.smartdevicelink.managers.SdlManager$2.run (SdlManager.java:218)
  at android.os.Handler.handleCallback (Handler.java:938)
  at android.os.Handler.dispatchMessage (Handler.java:99)
  at android.os.Looper.loop (Looper.java:254)
  at android.app.ActivityThread.main (ActivityThread.java:8218)
  at java.lang.reflect.Method.invoke (Native Method)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:632)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1049)

noah-livio added a commit that referenced this issue Jan 25, 2022
RHenigan pushed a commit that referenced this issue Feb 8, 2022
@theresalech
Copy link
Contributor

Closed via #1786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants