Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1881
This PR is [ready] for review.
Risk
This PR makes [no] API changes.
Testing Plan
Unit Tests
n/a
Core Tests
Test 1: (This is from our test plan using test suite and hello_sdl)
i. Change the UUID in MultiplexBluetoothTransport.SERVER_UUID to any other UUID
ii. Modify the way MainActivity starts the SdlService to manually start the SdlService instead of calling queryForConnectedServices
Test 2: (This is the accidental test I ran when I found the NPE)
Core version / branch / commit hash / module tested against: Sync 3
HMI name / version / branch / commit hash / module tested against: Sync 3
Summary
This PR fixes an NPE which can happen if we don't close the
routerServiceMessageEmitter
before we setrouterServiceMessenger
to null inTransportBroker.shutDownRouterServiceMessenger
Bug Fixes
CLA