remove iterator.toList for memory leak

smdmts · Jun 25, 2018 · dd0cf1d · dd0cf1d
1 parent 2e21f95
commit dd0cf1d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/build.gradle b/build.gradle
@@ -13,18 +13,18 @@ configurations {
     provided
 }
 
-version = "0.1.2"
+version = "0.1.3"
 
 sourceCompatibility = 1.7
 targetCompatibility = 1.7
 
 dependencies {
     compile "org.embulk:embulk-core:0.8.22"
     compile "org.scala-lang:scala-library:2.11.11"
-    compile group: 'com.sksamuel.avro4s', name: 'avro4s-core_2.11', version: '1.6.4'
+    compile group: 'com.sksamuel.avro4s', name: 'avro4s-core_2.11', version: '1.8.3'
     compile group: 'io.circe', name: 'circe-core_2.11', version: '0.8.0'
     compile group: 'io.circe', name: 'circe-generic_2.11', version: '0.8.0'
-    provided "org.embulk:embulk-core:0.8.22"
+    provided "org.embulk:embulk-core:0.9.7"
 }
 
 task classpath(type: Copy, dependsOn: ["jar"]) {

diff --git a/build.sbt b/build.sbt
@@ -19,9 +19,9 @@ resolvers += Resolver.sonatypeRepo("releases")
 
 lazy val circeVersion = "0.8.0"
 libraryDependencies ++= Seq(
-  "com.sksamuel.avro4s"        %% "avro4s-core"                 % "1.6.4",
+  "com.sksamuel.avro4s"        %% "avro4s-core"                 % "1.8.3",
   "org.jruby"                  % "jruby-complete"               % "1.6.5",
-  "org.embulk"                 % "embulk-core"                  % "0.8.22",
+  "org.embulk"                 % "embulk-core"                  % "0.9.7",
   "com.chuusai"                %% "shapeless"                   % "2.3.2",
   "io.circe"                   %% "circe-core"                  % circeVersion,
   "io.circe"                   %% "circe-generic"               % circeVersion,

diff --git a/src/main/scala/org/embulk/parser/firebase_avro/FirebaseAvroParserPlugin.scala b/src/main/scala/org/embulk/parser/firebase_avro/FirebaseAvroParserPlugin.scala
@@ -31,7 +31,7 @@ class FirebaseAvroParserPlugin extends ParserPlugin {
     LoanPattern(new PageBuilder(Exec.getBufferAllocator, schema, output)) { pb =>
       while (input.nextFile()) {
         val bytes = ByteStreams.toByteArray(new FileInputInputStream(input))
-        AvroInputStream.data[Root](bytes).iterator().toList.foreach { record =>
+        AvroInputStream.data[Root](bytes).iterator.foreach { record =>
           addRecords(pb, record)
         }
       }